From: Greg KH <gregkh@linuxfoundation.org>
To: Rocco Yue <rocco.yue@mediatek.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Felix Fietkau <nbd@nbd.name>, John Crispin <john@phrozen.org>,
Sean Wang <sean.wang@mediatek.com>,
Mark Lee <Mark-MC.Lee@mediatek.com>,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, bpf@vger.kernel.org,
wsd_upstream@mediatek.com, chao.song@mediatek.com,
zhuoliang.zhang@mediatek.com, kuohong.wang@mediatek.com
Subject: Re: [PATCH 4/4] drivers: net: mediatek: initial implementation of ccmni
Date: Wed, 23 Jun 2021 19:25:11 +0200 [thread overview]
Message-ID: <YNNudzDzzx7ZBwf+@kroah.com> (raw)
In-Reply-To: <20210623113452.5671-4-rocco.yue@mediatek.com>
On Wed, Jun 23, 2021 at 07:34:52PM +0800, Rocco Yue wrote:
> +EXPORT_SYMBOL(ccmni_rx_push);
Why are you exporting symbols that are not used by anyone in this patch
series? That doesn't feel right. Who needs this?
> +EXPORT_SYMBOL(ccmni_hif_hook);
Same with this, who calls this?
> +++ b/drivers/net/ethernet/mediatek/ccmni/ccmni.h
Why do you have a .h file for a single .c file? that shouldn't be
needed.
thanks,
greg k-h
next prev parent reply other threads:[~2021-06-23 17:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 11:34 [PATCH 1/4] net: if_arp: add ARPHRD_PUREIP type Rocco Yue
2021-06-23 11:34 ` [PATCH 2/4] net: ipv6: don't generate link local address on PUREIP device Rocco Yue
2021-06-23 11:34 ` [PATCH 3/4] net: dev_is_mac_header_xmit() return false for ARPHRD_PUREIP Rocco Yue
2021-06-23 11:34 ` [PATCH 4/4] drivers: net: mediatek: initial implementation of ccmni Rocco Yue
2021-06-23 17:25 ` Greg KH [this message]
2021-06-23 17:31 ` Greg KH
2021-06-24 11:53 ` [PATCH 1/4] net: if_arp: add ARPHRD_PUREIP type Rocco Yue
2021-06-24 12:23 ` Greg KH
2021-06-24 15:55 ` [PATCH 4/4] drivers: net: mediatek: initial implementation of ccmni Rocco Yue
2021-06-24 16:51 ` Greg KH
2021-06-28 7:18 ` Rocco Yue
2021-06-28 9:30 ` Greg KH
2021-06-23 17:19 ` [PATCH 1/4] net: if_arp: add ARPHRD_PUREIP type Greg KH
2021-06-24 3:33 ` Rocco Yue
2021-06-24 5:15 ` David Ahern
2021-06-24 5:31 ` Rocco Yue
2021-06-24 5:29 ` Greg KH
2021-06-24 6:13 ` Rocco Yue
2021-06-24 9:04 ` Greg KH
2021-06-24 12:24 ` Rocco Yue
2021-06-24 13:06 ` Greg KH
2021-06-25 6:01 ` Rocco Yue
2021-06-24 16:14 ` Dan Williams
2021-06-25 6:04 ` Rocco Yue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNNudzDzzx7ZBwf+@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Mark-MC.Lee@mediatek.com \
--cc=bpf@vger.kernel.org \
--cc=chao.song@mediatek.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=john@phrozen.org \
--cc=kuba@kernel.org \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=rocco.yue@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=wsd_upstream@mediatek.com \
--cc=yoshfuji@linux-ipv6.org \
--cc=zhuoliang.zhang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).