From: Andrew Lunn <andrew@lunn.ch>
To: Carlos Bilbao <bilbao@vt.edu>
Cc: gregkh@linuxfoundation.org, alexander.deucher@amd.com,
davem@davemloft.net, mchehab+huawei@kernel.org, kuba@kernel.org,
James.Bottomley@hansenpartnership.com, netdev@vger.kernel.org,
linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: Follow the indentation coding standard on printks
Date: Thu, 8 Jul 2021 16:53:48 +0200 [thread overview]
Message-ID: <YOcRfBtS/UJ81CFq@lunn.ch> (raw)
In-Reply-To: <2784471.e9J7NaK4W3@iron-maiden>
> --- a/drivers/atm/suni.c
> +++ b/drivers/atm/suni.c
> @@ -328,8 +328,8 @@ static int suni_start(struct atm_dev *dev)
> timer_setup(&poll_timer, suni_hz, 0);
> poll_timer.expires = jiffies+HZ;
> #if 0
> -printk(KERN_DEBUG "[u] p=0x%lx,n=0x%lx\n",(unsigned long) poll_timer.list.prev,
> - (unsigned long) poll_timer.list.next);
> + printk(KERN_DEBUG "[u] p=0x%lx,n=0x%lx\n",(unsigned long) poll_timer.list.prev,
> + (unsigned long) poll_timer.list.next);
Why not use DPRINTK(), defined at the start of suni.c?
Andrew
next prev parent reply other threads:[~2021-07-08 14:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 13:10 [PATCH] drivers: Follow the indentation coding standard on printks Carlos Bilbao
2021-07-08 14:40 ` Greg KH
2021-07-08 15:19 ` [PATCH] drivers: atm: " Carlos Bilbao
2021-07-08 15:48 ` Andrew Lunn
2021-07-08 17:06 ` Carlos Bilbao
2021-07-08 17:23 ` [PATCH net-next v2] " Carlos Bilbao
2021-07-08 17:27 ` Carlos Bilbao
2021-07-08 18:15 ` Andrew Lunn
2021-07-08 14:53 ` Andrew Lunn [this message]
2021-07-08 15:08 ` [PATCH] drivers: " Carlos Bilbao
2021-07-08 21:25 ` Rolf Eike Beer
2021-07-09 0:27 ` Stephen Hemminger
2021-07-09 6:43 ` Helge Deller
2021-07-09 10:30 ` bilbao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOcRfBtS/UJ81CFq@lunn.ch \
--to=andrew@lunn.ch \
--cc=James.Bottomley@hansenpartnership.com \
--cc=alexander.deucher@amd.com \
--cc=bilbao@vt.edu \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).