linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Thierry Reding <treding@nvidia.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Sebastian Reichel <sre@kernel.org>,
	Peter Chen <peter.chen@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Felipe Balbi <balbi@kernel.org>, David Heidelberg <david@ixit.cz>,
	devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: Re: [PATCH v1 04/12] usb: phy: tegra: Support OTG mode programming
Date: Fri, 9 Jul 2021 00:32:56 +0200	[thread overview]
Message-ID: <YOd9GE7xM150i1XT@qmqm.qmqm.pl> (raw)
In-Reply-To: <12f5b8cc-982e-f112-e0a4-21afdf3bce06@gmail.com>

On Thu, Jul 01, 2021 at 04:55:03PM +0300, Dmitry Osipenko wrote:
> 01.07.2021 05:23, Dmitry Osipenko пишет:
> >  static int tegra_usb_phy_init(struct usb_phy *u_phy)
> > @@ -967,12 +1057,26 @@ static int tegra_usb_phy_init(struct usb_phy *u_phy)
> >  			goto disable_vbus;
> >  	}
> >  
> > +	err = tegra_usb_phy_configure_pmc(phy);
> > +	if (err)
> > +		goto close_phy;
> > +
> >  	err = tegra_usb_phy_power_on(phy);
> >  	if (err)
> >  		goto close_phy;
> >  
> > +	if (phy->irq > 0) {
> > +		err = request_irq(phy->irq, tegra_usb_phy_isr, IRQF_SHARED,
> > +				  dev_name(phy->u_phy.dev), phy);
> > +		if (err)
> > +			goto pwr_off_phy;
> > +	}
> 
> There were reports that this patch was casing an unhandled USB interrupt
> event on some devices. I thought this problem was fixed already, but
> looking again at the offending kernel log again, it still should be a
> problem.
> 
> The interrupt fires from the usb_add_hcd() of the CI driver before CI
> driver have requested interrupt in ci_hdrc_probe(). So either CI driver
> should request interrupt earlier or Tegra PHY driver should keep shared
> interrupt disabled after requesting it, the latter variant should be
> more robust. I'll improve it in v2.

I'd suggest the first solution, as the latter is a workaround for what
is a normal shared interrupt behaviour. Maybe a controller reset is
needed in CI driver before going on with PHY init?

Best Regards
Michał Mirosław

  reply	other threads:[~2021-07-08 22:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-01  2:23 [PATCH v1 00/12] Add OTG mode support to Tegra USB PHY, SMB347 and Nexus 7 Dmitry Osipenko
2021-07-01  2:23 ` [PATCH v1 01/12] dt-bindings: phy: tegra20-usb-phy: Convert to schema Dmitry Osipenko
2021-07-01  2:23 ` [PATCH v1 02/12] dt-bindings: phy: tegra20-usb-phy: Document properties needed for OTG mode Dmitry Osipenko
2021-07-01  2:23 ` [PATCH v1 03/12] soc/tegra: pmc: Expose USB regmap to all SoCs Dmitry Osipenko
2021-07-01  2:23 ` [PATCH v1 04/12] usb: phy: tegra: Support OTG mode programming Dmitry Osipenko
2021-07-01 13:55   ` Dmitry Osipenko
2021-07-08 22:32     ` Michał Mirosław [this message]
2021-07-09 21:29       ` Dmitry Osipenko
2021-07-01  2:23 ` [PATCH v1 05/12] usb: otg-fsm: Fix hrtimer list corruption Dmitry Osipenko
2021-07-08 22:42   ` Michał Mirosław
2021-07-09 21:30     ` Dmitry Osipenko
2021-07-01  2:23 ` [PATCH v1 06/12] dt-bindings: power: supply: smb347-charger: Document USB VBUS regulator Dmitry Osipenko
2021-07-01  2:24 ` [PATCH v1 07/12] power: supply: smb347-charger: Make smb347_set_writable() IRQ-safe Dmitry Osipenko
2021-07-01  2:24 ` [PATCH v1 08/12] power: supply: smb347-charger: Remove caching of charger state Dmitry Osipenko
2021-07-01  2:24 ` [PATCH v1 09/12] power: supply: smb347-charger: Implement USB VBUS regulator Dmitry Osipenko
2021-07-01  2:24 ` [PATCH v1 10/12] arm64: tegra132: Add new properties to USB PHY device-tree node Dmitry Osipenko
2021-07-01  2:24 ` [PATCH v1 11/12] ARM: tegra: Add new properties to USB PHY device-tree nodes Dmitry Osipenko
2021-07-01  2:24 ` [PATCH v1 12/12] ARM: tegra: nexus7: Enable USB OTG mode Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YOd9GE7xM150i1XT@qmqm.qmqm.pl \
    --to=mirq-linux@rere.qmqm.pl \
    --cc=balbi@kernel.org \
    --cc=broonie@kernel.org \
    --cc=david@ixit.cz \
    --cc=devicetree@vger.kernel.org \
    --cc=digetx@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=peter.chen@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sre@kernel.org \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).