From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4CE4C07E99 for ; Mon, 12 Jul 2021 13:57:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A37E86101D for ; Mon, 12 Jul 2021 13:57:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234886AbhGLOAb (ORCPT ); Mon, 12 Jul 2021 10:00:31 -0400 Received: from mga01.intel.com ([192.55.52.88]:1072 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234125AbhGLOAa (ORCPT ); Mon, 12 Jul 2021 10:00:30 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10042"; a="231774443" X-IronPort-AV: E=Sophos;i="5.84,234,1620716400"; d="scan'208";a="231774443" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jul 2021 06:57:41 -0700 X-IronPort-AV: E=Sophos;i="5.84,234,1620716400"; d="scan'208";a="502176636" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jul 2021 06:57:40 -0700 Received: from andy by smile with local (Exim 4.94.2) (envelope-from ) id 1m2wRD-00CFZc-3k; Mon, 12 Jul 2021 16:57:35 +0300 Date: Mon, 12 Jul 2021 16:57:35 +0300 From: Andy Shevchenko To: Greg Kroah-Hartman , Alexander Gordeev Cc: linux-kernel@vger.kernel.org, Rodolfo Giometti Subject: Re: [PATCH v1 1/1] pps: generators: pps_gen_parport: Switch to use module_parport_driver() Message-ID: References: <20210616143121.46059-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 16, 2021 at 04:44:38PM +0200, Greg Kroah-Hartman wrote: > On Wed, Jun 16, 2021 at 05:31:21PM +0300, Andy Shevchenko wrote: > > Switch to use module_parport_driver() to reduce boilerplate code. > > + pr_info("hrtimer avg error is %ldns\n", hrtimer_error); > > Why is this line needed? When drivers work properly, they are quiet. > > I know the existing code has it, no reason it needs to stay here, that's > why we created these macros, to remove the ability for drivers to be > printing junk like this that they do not need to be printing. Seems the original authors keeps silent. What do you suggest in this case? Remove the line and resubmit? -- With Best Regards, Andy Shevchenko