From: Matthew Wilcox <willy@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: syzbot <syzbot+bb4c69145b4a52b40b27@syzkaller.appspotmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] BUG: sleeping function called from invalid context in folio_copy
Date: Mon, 26 Jul 2021 13:45:40 +0100 [thread overview]
Message-ID: <YP6udKVlejbnTOiw@casper.infradead.org> (raw)
In-Reply-To: <20210725221834.35e077daff0005f3d78d08d7@linux-foundation.org>
On Sun, Jul 25, 2021 at 10:18:34PM -0700, Andrew Morton wrote:
> (Cc Matthew)
>
> (It might not be a folio thing at all - I haven't checked yet)
Already fixed, thanks. folio_copy() had a cond_resched() in it,
even if it was only copying a single page. Now it only calls
cond_resched() if it's copying more than one page.
We discussed this in the folio call on Friday, because we're leaving a
bit of a landmine here for whoever tries to make multi-page folios work
with buffer_heads. There's not much we can do about it for now; it'll
just be one of the many problems to be dealt with. Hopefully filesystems
will convert to iomap instead of trying to make buffer_heads support
multiple pages.
prev parent reply other threads:[~2021-07-26 12:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-25 8:18 [syzbot] BUG: sleeping function called from invalid context in folio_copy syzbot
2021-07-26 5:18 ` Andrew Morton
2021-07-26 12:45 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YP6udKVlejbnTOiw@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=syzbot+bb4c69145b4a52b40b27@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).