From: Greg KH <gregkh@linuxfoundation.org>
To: Michael Broadfoot <msbroadf@gmail.com>
Cc: valentina.manea.m@gmail.com, shuah@kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vhci_hcd: Always re-enable a USB Port after reset
Date: Wed, 21 Jul 2021 11:54:59 +0200 [thread overview]
Message-ID: <YPfu878Y1Og7zwd7@kroah.com> (raw)
In-Reply-To: <20210721094922.15642-1-msbroadf@gmail.com>
On Wed, Jul 21, 2021 at 07:49:22PM +1000, Michael Broadfoot wrote:
> A (virtual) usb port can getting stuck in a disabled state on reset
How can that happen?
> Always re-enable a usb port regardless of if its addressed or not
Are you sure? What causes this?
And what do you mean by "not" here?
Please write full sentences.
>
> Signed-off-by: Michael Broadfoot <msbroadf@gmail.com>
> ---
> drivers/usb/usbip/vhci_hcd.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
> index 4ba6bcdaa8e9..cea3781d04e6 100644
> --- a/drivers/usb/usbip/vhci_hcd.c
> +++ b/drivers/usb/usbip/vhci_hcd.c
> @@ -455,15 +455,12 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,
> vhci_hcd->port_status[rhport] &= ~(1 << USB_PORT_FEAT_RESET);
> vhci_hcd->re_timeout = 0;
>
> - if (vhci_hcd->vdev[rhport].ud.status ==
> - VDEV_ST_NOTASSIGNED) {
> usbip_dbg_vhci_rh(
> " enable rhport %d (status %u)\n",
> rhport,
> vhci_hcd->vdev[rhport].ud.status);
> vhci_hcd->port_status[rhport] |=
> USB_PORT_STAT_ENABLE;
> - }
Coding style is now all messed up, this change isn't ok as-is, sorry.
thanks,
greg k-h
prev parent reply other threads:[~2021-07-21 10:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 9:49 [PATCH] vhci_hcd: Always re-enable a USB Port after reset Michael Broadfoot
2021-07-21 9:54 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPfu878Y1Og7zwd7@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=msbroadf@gmail.com \
--cc=shuah@kernel.org \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).