From: Rob Herring <robh@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>, Bert Vermeulen <bert@biot.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
soc@kernel.org, John Crispin <john@phrozen.org>,
Felix Fietkau <nbd@nbd.name>
Subject: Re: [PATCH 3/5] ARM: dts: Add basic support for EcoNet EN7523
Date: Fri, 6 Aug 2021 14:52:41 -0600 [thread overview]
Message-ID: <YQ2hGd1cERLbfjJ6@robh.at.kernel.org> (raw)
In-Reply-To: <20210730145901.GC19569@C02TD0UTHF1T.local>
On Fri, Jul 30, 2021 at 03:59:01PM +0100, Mark Rutland wrote:
> On Fri, Jul 30, 2021 at 03:45:50PM +0200, Bert Vermeulen wrote:
> > From: John Crispin <john@phrozen.org>
> >
> > Add basic support for EcoNet EN7523, enough for booting to console.
> >
> > The UART is basically 8250-compatible, except for the clock selection.
> > A clock-frequency value is synthesized to get this to run at 115200 bps.
> >
> > Signed-off-by: John Crispin <john@phrozen.org>
> > Signed-off-by: Bert Vermeulen <bert@biot.com>
> > ---
> > arch/arm/boot/dts/Makefile | 2 +
> > arch/arm/boot/dts/en7523-evb.dts | 17 ++++
> > arch/arm/boot/dts/en7523.dtsi | 128 +++++++++++++++++++++++++++++++
> > 3 files changed, 147 insertions(+)
> > create mode 100644 arch/arm/boot/dts/en7523-evb.dts
> > create mode 100644 arch/arm/boot/dts/en7523.dtsi
> >
>
> > + cpus {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
>
> > + cpu0: cpu@0 {
> > + device_type = "cpu";
> > + compatible = "arm,cortex-a7";
> > + reg = <0x0>;
> > + enable-method = "psci";
> > + clock-frequency = <80000000>;
> > + next-level-cache = <&L2_0>;
> > +
> > + };
>
> > + gic: interrupt-controller@09000000 {
> > + compatible = "arm,gic-v3";
> > + interrupt-controller;
> > + #interrupt-cells = <3>;
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + reg = <0x09000000 0x20000>,
> > + <0x09080000 0x80000>;
> > + interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_LOW>;
> > +
> > + its: gic-its@09020000 {
> > + compatible = "arm,gic-v3-its";
> > + msi-controller;
> > + #msi-cell = <1>;
>
> Missing 's' here for '#msi-cells'.
No need for a human to be checking this, the DT schemas will check this.
Please run 'make dtbs_checks' on this. New platforms should be free of
warnings ideally.
Rob
next prev parent reply other threads:[~2021-08-06 20:52 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 13:45 [PATCH 0/4] Add support for EcoNet EN7523 SoC Bert Vermeulen
2021-07-30 13:45 ` [PATCH 1/5] dt-bindings: Add vendor prefix for EcoNet Bert Vermeulen
2021-08-06 21:02 ` Rob Herring
2021-07-30 13:45 ` [PATCH 2/5] dt-bindings: arm: econet: Add binding for EN7523 SoC and EVB Bert Vermeulen
2021-08-06 21:04 ` Rob Herring
2021-07-30 13:45 ` [PATCH 3/5] ARM: dts: Add basic support for EcoNet EN7523 Bert Vermeulen
2021-07-30 14:31 ` Linus Walleij
[not found] ` <87y29n26po.wl-maz@kernel.org>
2021-08-01 9:07 ` Bert Vermeulen
2021-08-01 9:40 ` Arnd Bergmann
2021-07-30 14:45 ` Daniel Palmer
2021-07-30 14:46 ` Mark Rutland
2021-08-04 16:41 ` Bert Vermeulen
2021-08-06 20:59 ` Rob Herring
2021-07-30 14:59 ` Mark Rutland
2021-08-06 20:52 ` Rob Herring [this message]
2021-07-30 16:47 ` Andre Przywara
2021-07-30 13:45 ` [PATCH 4/5] ARM: Add basic support for EcoNet EN7523 SoC Bert Vermeulen
2021-07-30 14:48 ` Arnd Bergmann
2021-07-30 15:15 ` John Crispin
2021-07-30 16:55 ` Arnd Bergmann
2021-08-01 16:44 ` Ard Biesheuvel
2021-09-03 16:20 ` Felix Fietkau
2021-09-03 17:47 ` Ard Biesheuvel
2021-08-04 16:43 ` Bert Vermeulen
2021-08-09 12:46 ` Geert Uytterhoeven
2021-08-09 12:49 ` Ard Biesheuvel
2021-08-09 13:00 ` Bert Vermeulen
2021-07-30 13:45 ` [PATCH 5/5] ARM: multi_v7_defconfig: Add " Bert Vermeulen
2021-07-30 14:26 ` [PATCH 0/4] " Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQ2hGd1cERLbfjJ6@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=arnd@arndb.de \
--cc=bert@biot.com \
--cc=devicetree@vger.kernel.org \
--cc=john@phrozen.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nbd@nbd.name \
--cc=olof@lixom.net \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).