From: Eric Biggers <ebiggers@kernel.org>
To: Shreeya Patel <shreeya.patel@collabora.com>
Cc: krisman@collabora.com, tytso@mit.edu, adilger.kernel@dilger.ca,
jaegeuk@kernel.org, chao@kernel.org, drosen@google.com,
yuchao0@huawei.com, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, kernel@collabora.com,
andre.almeida@collabora.com
Subject: Re: [PATCH] fs: unicode: Add utf8-data module
Date: Sat, 7 Aug 2021 09:55:51 -0700 [thread overview]
Message-ID: <YQ67FxJRlfTj5EGy@sol.localdomain> (raw)
In-Reply-To: <20210730124333.6744-1-shreeya.patel@collabora.com>
On Fri, Jul 30, 2021 at 06:13:33PM +0530, Shreeya Patel wrote:
> diff --git a/fs/unicode/utf8n.h b/fs/unicode/utf8n.h
> index 0acd530c2c79..6843229bcb2b 100644
> --- a/fs/unicode/utf8n.h
> +++ b/fs/unicode/utf8n.h
> @@ -11,6 +11,7 @@
> #include <linux/export.h>
> #include <linux/string.h>
> #include <linux/module.h>
> +#include <linux/spinlock.h>
>
> /* Encoding a unicode version number as a single unsigned int. */
> #define UNICODE_MAJ_SHIFT (16)
> @@ -21,6 +22,11 @@
> ((unsigned int)(MIN) << UNICODE_MIN_SHIFT) | \
> ((unsigned int)(REV)))
>
> +extern spinlock_t utf8_lock;
> +
> +extern struct utf8_data *utf8_ops;
> +extern bool utf8data_loaded;
The 'utf8data_loaded' variable is unnecessary, since it's equivalent to
'utf8_ops != NULL'.
Also, there are no function pointer fields anymore, so this really should be
called utf8_data, not utf8_ops.
- Eric
prev parent reply other threads:[~2021-08-07 16:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 12:43 [PATCH] fs: unicode: Add utf8-data module Shreeya Patel
2021-08-07 16:55 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQ67FxJRlfTj5EGy@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=andre.almeida@collabora.com \
--cc=chao@kernel.org \
--cc=drosen@google.com \
--cc=jaegeuk@kernel.org \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shreeya.patel@collabora.com \
--cc=tytso@mit.edu \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).