From: Andrew Lunn <andrew@lunn.ch>
To: Michael Walle <michael@walle.cc>
Cc: Daniel Golle <daniel@makrotopia.org>,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] ARM: kirkwood: add missing <linux/if_ether.h> for ETH_ALEN
Date: Sat, 7 Aug 2021 16:17:44 +0200 [thread overview]
Message-ID: <YQ6WCK0Sytb0nxj9@lunn.ch> (raw)
In-Reply-To: <cde9de20efd3a75561080751766edbec@walle.cc>
> What kernel is this? I've just tested with this exact commit as
> base and it compiles just fine.
>
> I'm not saying including the file is wrong, but it seems it isn't
> needed in the upstream kernel and I don't know if it qualifies for
> the stable queue therefore.
I would like to see a reproducer for mainline. Do you have a kernel
config which generates the problem.
The change itself does seems reasonable, so if we can reproduce it, i
would be happy to merge it for stable.
Andrew
next prev parent reply other threads:[~2021-08-07 14:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 22:23 [PATCH] ARM: kirkwood: add missing <linux/if_ether.h> for ETH_ALEN Daniel Golle
2021-08-06 7:21 ` Michael Walle
2021-08-07 14:17 ` Andrew Lunn [this message]
2021-08-08 3:27 ` Daniel Golle
2021-08-08 15:18 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQ6WCK0Sytb0nxj9@lunn.ch \
--to=andrew@lunn.ch \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).