From: Vinod Koul <vkoul@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: wangzhou1@hisilicon.com, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] dmaengine: hisi_dma: Remove some useless code
Date: Wed, 28 Jul 2021 12:22:13 +0530 [thread overview]
Message-ID: <YQD+ncEBh4TiM406@matsya> (raw)
In-Reply-To: <4f8932e2d0d8d092bf60272511100030e013bc72.1623875508.git.christophe.jaillet@wanadoo.fr>
On 16-06-21, 22:34, Christophe JAILLET wrote:
> When using 'pcim_enable_device()', 'pci_alloc_irq_vectors()' is
> auto-magically a managed function.
>
> It is useless (but harmless) to record an action to explicitly call
> 'pci_free_irq_vectors()'.
>
> So keep things simple, comment why and how these resources are freed, axe
> some useless code and save some memory.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2021-07-28 6:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 20:34 [PATCH] dmaengine: hisi_dma: Remove some useless code Christophe JAILLET
2021-07-28 6:52 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQD+ncEBh4TiM406@matsya \
--to=vkoul@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dmaengine@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangzhou1@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).