From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: longli@linuxonhyperv.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hyperv@vger.kernel.org, Long Li <longli@microsoft.com>,
Jonathan Corbet <corbet@lwn.net>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Hans de Goede <hdegoede@redhat.com>,
Dan Williams <dan.j.williams@intel.com>,
Maximilian Luz <luzmaximilian@gmail.com>,
Mike Rapoport <rppt@kernel.org>,
Ben Widawsky <ben.widawsky@intel.com>,
Jiri Slaby <jirislaby@kernel.org>,
Andra Paraschiv <andraprs@amazon.com>,
Siddharth Gupta <sidgup@codeaurora.org>,
Hannes Reinecke <hare@suse.de>,
linux-doc@vger.kernel.org
Subject: Re: [Patch v5 2/3] Drivers: hv: add Azure Blob driver
Date: Thu, 5 Aug 2021 09:11:33 +0200 [thread overview]
Message-ID: <YQuPJUX4+HZ3FeKC@kroah.com> (raw)
In-Reply-To: <1628146812-29798-3-git-send-email-longli@linuxonhyperv.com>
On Thu, Aug 05, 2021 at 12:00:11AM -0700, longli@linuxonhyperv.com wrote:
> +static int az_blob_create_device(struct az_blob_device *dev)
> +{
> + int ret;
> + struct dentry *debugfs_root;
> +
> + dev->misc.minor = MISC_DYNAMIC_MINOR,
> + dev->misc.name = "azure_blob",
> + dev->misc.fops = &az_blob_client_fops,
> +
> + ret = misc_register(&dev->misc);
> + if (ret)
> + return ret;
> +
> + debugfs_root = debugfs_create_dir("az_blob", NULL);
So you try to create a directory in the root of debugfs called "az_blob"
for every device in the system of this one type?
That will blow up when you have multiple devices of the same type,
please fix.
thanks,
greg k-h
next prev parent reply other threads:[~2021-08-05 7:11 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 7:00 [Patch v5 0/3] Introduce a driver to support host accelerated access to Microsoft Azure Blob for Azure VM longli
2021-08-05 7:00 ` [Patch v5 1/3] Drivers: hv: vmbus: add support to ignore certain PCIE devices longli
2021-08-05 7:00 ` [Patch v5 2/3] Drivers: hv: add Azure Blob driver longli
2021-08-05 7:11 ` Greg Kroah-Hartman [this message]
2021-08-05 18:07 ` Long Li
2021-08-05 18:16 ` Greg Kroah-Hartman
2021-08-05 17:06 ` Bart Van Assche
2021-08-05 18:10 ` Long Li
2021-08-05 18:17 ` Greg Kroah-Hartman
2021-09-07 21:42 ` Michael Kelley
2021-08-05 7:00 ` [Patch v5 3/3] Drivers: hv: Add to maintainer for Hyper-V/Azure drivers longli
2021-08-05 7:08 ` [Patch v5 0/3] Introduce a driver to support host accelerated access to Microsoft Azure Blob for Azure VM Greg Kroah-Hartman
2021-08-05 18:27 ` Long Li
2021-08-05 18:33 ` Greg Kroah-Hartman
2021-08-05 17:09 ` Bart Van Assche
2021-08-05 18:24 ` Long Li
2021-08-05 18:34 ` Greg Kroah-Hartman
2021-08-07 18:29 ` Long Li
2021-08-08 5:14 ` Greg Kroah-Hartman
2021-08-10 3:01 ` Long Li
2021-09-22 23:55 ` Long Li
2021-09-30 22:25 ` Long Li
2021-10-01 7:36 ` Greg Kroah-Hartman
2021-10-07 18:15 ` Long Li
2021-10-08 5:54 ` Greg Kroah-Hartman
2021-10-08 11:11 ` Vitaly Kuznetsov
2021-10-08 11:19 ` Greg Kroah-Hartman
2021-10-08 13:28 ` Vitaly Kuznetsov
2021-10-11 17:57 ` Long Li
2021-10-13 0:58 ` Long Li
2021-10-13 7:03 ` Greg Kroah-Hartman
2021-10-11 17:55 ` Long Li
2021-10-11 17:46 ` Long Li
2021-10-11 17:58 ` Greg Kroah-Hartman
2021-10-11 19:38 ` Long Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQuPJUX4+HZ3FeKC@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andraprs@amazon.com \
--cc=ben.widawsky@intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hare@suse.de \
--cc=hdegoede@redhat.com \
--cc=jirislaby@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@linuxonhyperv.com \
--cc=longli@microsoft.com \
--cc=luzmaximilian@gmail.com \
--cc=rppt@kernel.org \
--cc=sidgup@codeaurora.org \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).