From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF3F8C432BE for ; Thu, 5 Aug 2021 17:51:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8E6C6112F for ; Thu, 5 Aug 2021 17:51:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240777AbhHERvp (ORCPT ); Thu, 5 Aug 2021 13:51:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:38226 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236297AbhHERvn (ORCPT ); Thu, 5 Aug 2021 13:51:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 176AF610A2; Thu, 5 Aug 2021 17:51:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1628185889; bh=5jNjejyjxB7nwfUqDY9J1juhKh4IHwjC1LQw9Czvn0s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=O0U2Rduft6AQmfcB8IFmxBcBpgCDSzI2fZI16xXYHSWXvqNx9IGlG1OrG/WlVZNiF 567k3XoLLUD1Q4ynHes8cLrnUBq1BRCfIsLvrIENZnwcwOURDgr2pnSiVZJDUtutPu vuXOxfVd7Cn2X4fNA9Pw4PWfhO9dY3bB0LY9nKVE= Date: Thu, 5 Aug 2021 19:51:26 +0200 From: Greg Kroah-Hartman To: Andi Kleen Cc: Kuppuswamy Sathyanarayanan , "Rafael J . Wysocki" , Jonathan Corbet , Dan Williams , Kuppuswamy Sathyanarayanan , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v1] driver: base: Add driver filter support Message-ID: References: <20210804174322.2898409-1-sathyanarayanan.kuppuswamy@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 05, 2021 at 06:52:25AM -0700, Andi Kleen wrote: > > > Both thunderbolt and USB have the idea of "authorized" devices, that is > > the logic that should be made generic and available for all busses to > > use, by moving it to the driver core, just like the "removable" logic > > got moved to the driver core recently (see 70f400d4d957 ("driver core: > > Move the "removable" attribute from USB to core") > > This looks like it's controlled by udev?  Have a default per bus, and let > user space override it before setting up the device. It's controlled by whatever you want to use in userspace. usbguard has been handling this logic in userspace for over a decade now just fine. > This doesn't help us handle builtin drivers that initialize before user > space is up. Then have the default setting for your bus be "unauthorized" like we allow for some busses today. > We need something that works for all drivers. Also cannot just use a default > at bootup because some drivers (like virtio or rtc) need to be initialized > in early boot to make the system functional at all. So you need a way to > distinguish these two cases in the pre user space boot. > > That's basically what this patch implements the infrastructure for. It also ignores the existing implementation we already have for this for some busses, please do not do that. > > Please use that type of interface, as we already have userspace tools > > using it, and expand it for all busses in the system to use if they > > want. Otherwise with this proposal you will end up with multiple ways > > to control the same bus type with different types of "filtering", > > ensuring a mess. > > How would such a proposal work for a platform driver that doesn't have a > bus? There is a platform bus, it's just a fake one. The platform bus code does the binding just like any other bus does, why is platform somehow "special"? Except for how it is abused... thanks, greg k-h