From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 657A3C4338F for ; Fri, 20 Aug 2021 17:34:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 44FE761101 for ; Fri, 20 Aug 2021 17:34:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234730AbhHTRfd (ORCPT ); Fri, 20 Aug 2021 13:35:33 -0400 Received: from mail.skyhub.de ([5.9.137.197]:51410 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230214AbhHTRfb (ORCPT ); Fri, 20 Aug 2021 13:35:31 -0400 Received: from zn.tnic (p200300ec2f107b00196adb237f9ce365.dip0.t-ipconnect.de [IPv6:2003:ec:2f10:7b00:196a:db23:7f9c:e365]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id D96FE1EC0589; Fri, 20 Aug 2021 19:34:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1629480889; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=ra/7mQW79+c0tVxtuse8aU6V6XyXHtuoSW3joNYRlng=; b=gVbbTxnVt7SsxSFRW7lW/CZ2MJ8YrW1G19OVz5PnQzGP+/BUG/yN0Mz67sy1ty/4rl2A0P VB0y19VNMdrfFw4xAPm9zIhbx1dRRx7EUe4yin4ly07hFmkjJ24eCwKoSkdrHjKXq2XFu0 g/flruk96bX90jJoykhYUfUY6muA28k= Date: Fri, 20 Aug 2021 19:35:32 +0200 From: Borislav Petkov To: "Kuppuswamy, Sathyanarayanan" Cc: Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Andy Lutomirski , Peter H Anvin , Dave Hansen , Tony Luck , Dan Williams , Andi Kleen , Kirill Shutemov , Sean Christopherson , Kuppuswamy Sathyanarayanan , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 06/12] x86/tdx: Get TD execution environment information via TDINFO Message-ID: References: <20210804181329.2899708-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20210804181329.2899708-7-sathyanarayanan.kuppuswamy@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 20, 2021 at 10:31:10AM -0700, Kuppuswamy, Sathyanarayanan wrote: > It is used in different patch set. If you prefer to move it there, I can > move it to that patch set. Yes please. > I have already fixed reasonable check-patch issues. For this case, we > want to use BUG_ON(). Failure in tdx_module_call means buggy TDX > module. So it is safer to crash the kernel. Ok, put that as a comment above it to explain why it cannot continue. Also, make sure you issue an error message before it explodes so that the user knows. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette