From: Joerg Roedel <jroedel@suse.de>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Joerg Roedel <joro@8bytes.org>,
David Laight <David.Laight@aculab.com>,
"x86@kernel.org" <x86@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"hpa@zytor.com" <hpa@zytor.com>,
Kees Cook <keescook@chromium.org>,
Andy Lutomirski <luto@kernel.org>,
Uros Bizjak <ubizjak@gmail.com>,
Arvind Sankar <nivedita@alum.mit.edu>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Fabio Aiuto <fabioaiuto83@gmail.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] x86/efi: Restore Firmware IDT in before ExitBootServices()
Date: Fri, 20 Aug 2021 13:51:23 +0200 [thread overview]
Message-ID: <YR+XO+zcwoNytZSj@suse.de> (raw)
In-Reply-To: <CAMj1kXHj12FQn_488V_9k9k_LE51K=7n3sS9QnN9gkhBgzw-Kw@mail.gmail.com>
On Fri, Aug 20, 2021 at 01:31:36PM +0200, Ard Biesheuvel wrote:
> That does raise a question, though. Does changing the IDT interfere
> with the ability of the UEFI boot services to receive and handle the
> timer interrupt? Because before ExitBootServices(), that is owned by
> the firmware, and UEFI heavily relies on it for everything (event
> handling, polling mode block/network drivers, etc)
Yes it would interfer, if the boot code would run with IRQs enabled,
which it does not. But switching the GDT also interfers with that, and
we are doing the same switching with the GDT already.
> If restoring the IDT temporarily just papers over this by creating
> tiny windows where the timer interrupt starts working again, this is
> bad, and we need to figure out another way to address the original
> problem.
As I can see it, there is no time window where an interrupt could happen
(NMIs aside). When returning from EFI IRQs are disabled again (in case
EFI let them enabled) while still on the EFI GDT and IDT. After IRQs are
disabled the kernel restores its own GDT and IDT.
Regards,
Joerg
next prev parent reply other threads:[~2021-08-20 11:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 7:34 [PATCH] x86/efi: Restore Firmware IDT in before ExitBootServices() Joerg Roedel
2021-08-20 7:41 ` Ard Biesheuvel
2021-08-20 8:01 ` Joerg Roedel
2021-08-20 8:43 ` David Laight
2021-08-20 8:52 ` 'Joerg Roedel'
2021-08-20 9:02 ` David Laight
2021-08-20 10:19 ` 'Joerg Roedel'
2021-08-20 11:31 ` Ard Biesheuvel
2021-08-20 11:51 ` Joerg Roedel [this message]
2021-08-20 15:46 ` David Laight
2021-08-20 16:04 ` Joerg Roedel
2021-08-20 9:26 ` Borislav Petkov
2021-08-20 11:24 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YR+XO+zcwoNytZSj@suse.de \
--to=jroedel@suse.de \
--cc=David.Laight@aculab.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=fabioaiuto83@gmail.com \
--cc=hpa@zytor.com \
--cc=joro@8bytes.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=nivedita@alum.mit.edu \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=ubizjak@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).