From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Liu Bo <bo.liu@linux.alibaba.com>
Cc: linux-erofs@lists.ozlabs.org, Chao Yu <chao@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Peng Tao <tao.peng@linux.alibaba.com>,
Eryu Guan <eguan@linux.alibaba.com>,
Liu Jiang <gerry@linux.alibaba.com>,
Joseph Qi <joseph.qi@linux.alibaba.com>
Subject: Re: [PATCH 1/2] erofs: introduce chunk-based file on-disk format
Date: Thu, 19 Aug 2021 08:59:24 +0800 [thread overview]
Message-ID: <YR2s7Gj7RDl7TaVn@B-P7TQMD6M-0146.local> (raw)
In-Reply-To: <20210818222804.GA73193@rsjd01523.et2sqa>
Hi Bo,
On Thu, Aug 19, 2021 at 06:28:04AM +0800, Liu Bo wrote:
> On Wed, Aug 18, 2021 at 03:07:12PM +0800, Gao Xiang wrote:
...
> > + EROFS_INODE_CHUNK_BASED = 4,
> > EROFS_INODE_DATALAYOUT_MAX
> > };
> >
> > @@ -90,6 +96,19 @@ static inline bool erofs_inode_is_data_compressed(unsigned int datamode)
> > #define EROFS_I_ALL \
> > ((1 << (EROFS_I_DATALAYOUT_BIT + EROFS_I_DATALAYOUT_BITS)) - 1)
> >
> > +/* indicate chunk blkbits, thus `chunksize = blocksize << chunk blkbits' */
>
> A typo in the quotation marks. (`chunksize = ) should be ('chunksize =)
Such usage is like below:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0e389028ad75412ff624b304913bba14f8d46ec4
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=78128fabd022240852859c0b253972147593690b
I'm fine in either way. I'll update it in the next version or when
submitting.
>
> Otherwise it looks good.
>
> Reviewed-by: Liu Bo <bo.liu@linux.alibaba.com>
Thanks for the review!
Thanks,
Gao Xiang
>
> thanks,
> liubo
>
next prev parent reply other threads:[~2021-08-19 0:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 7:07 [PATCH 1/2] erofs: introduce chunk-based file on-disk format Gao Xiang
2021-08-18 7:07 ` [PATCH 2/2] erofs: support reading chunk-based uncompressed files Gao Xiang
2021-08-18 22:29 ` Liu Bo
2021-08-19 3:46 ` Chao Yu
2021-08-19 5:14 ` Gao Xiang
2021-08-18 22:28 ` [PATCH 1/2] erofs: introduce chunk-based file on-disk format Liu Bo
2021-08-19 0:59 ` Gao Xiang [this message]
2021-08-19 3:32 ` Chao Yu
2021-08-19 6:33 ` [PATCH v2 " Gao Xiang
2021-08-19 6:33 ` [PATCH v2 2/2] erofs: support reading chunk-based uncompressed files Gao Xiang
2021-08-19 6:37 ` Joseph Qi
2021-08-19 7:12 ` Gao Xiang
2021-08-20 9:04 ` Chao Yu
2021-08-20 9:12 ` Gao Xiang
2021-08-20 9:29 ` Chao Yu
2021-08-20 9:33 ` Gao Xiang
2021-08-20 10:00 ` [PATCH v3 1/2] erofs: introduce chunk-based file on-disk format Gao Xiang
2021-08-20 10:00 ` [PATCH v3 2/2] erofs: support reading chunk-based uncompressed files Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YR2s7Gj7RDl7TaVn@B-P7TQMD6M-0146.local \
--to=hsiangkao@linux.alibaba.com \
--cc=bo.liu@linux.alibaba.com \
--cc=chao@kernel.org \
--cc=eguan@linux.alibaba.com \
--cc=gerry@linux.alibaba.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tao.peng@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).