From: Nathan Chancellor <nathan@kernel.org>
To: Maciej Falkowski <maciej.falkowski9@gmail.com>
Cc: natechancellor@gmail.com, ndesaulniers@google.com,
masahiroy@kernel.org, michal.lkml@markovi.net, nhuck@google.com,
clang-built-linux@googlegroups.com, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] clang-tools: Print information when clang-tidy tool is missing
Date: Sun, 8 Aug 2021 15:18:04 -0700 [thread overview]
Message-ID: <YRBYHAJSpU5jcTQV@Ryzen-9-3900X.localdomain> (raw)
In-Reply-To: <20210807110116.7985-1-maciej.falkowski9@gmail.com>
On Sat, Aug 07, 2021 at 01:01:16PM +0200, Maciej Falkowski wrote:
> When clang-tidy tool is missing in the system, the FileNotFoundError
> exception is raised in the program reporting a stack trace to the user:
>
> $ ./scripts/clang-tools/run-clang-tools.py clang-tidy ./compile_commands.json
> multiprocessing.pool.RemoteTraceback:
> """
> Traceback (most recent call last):
> File "/usr/lib64/python3.8/multiprocessing/pool.py", line 125, in worker
> result = (True, func(*args, **kwds))
> File "/usr/lib64/python3.8/multiprocessing/pool.py", line 48, in mapstar
> return list(map(*args))
> File "./scripts/clang-tools/run-clang-tools.py", line 54, in run_analysis
> p = subprocess.run(["clang-tidy", "-p", args.path, checks, entry["file"]],
> File "/usr/lib64/python3.8/subprocess.py", line 489, in run
> with Popen(*popenargs, **kwargs) as process:
> File "/usr/lib64/python3.8/subprocess.py", line 854, in __init__
> self._execute_child(args, executable, preexec_fn, close_fds,
> File "/usr/lib64/python3.8/subprocess.py", line 1702, in _execute_child
> raise child_exception_type(errno_num, err_msg, err_filename)
> FileNotFoundError: [Errno 2] No such file or directory: 'clang-tidy'
> """
>
> The patch adds more user-friendly information about missing tool:
>
> $ ./scripts/clang-tools/run-clang-tools.py clang-tidy ./compile_commands.json
> Command 'clang-tidy' is missing in the system
>
> Signed-off-by: Maciej Falkowski <maciej.falkowski9@gmail.com>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1342
LGTM, I think this is much better than the stacktrace output as above as
it is easier for someone who is not familiar with these scrips to act
on.
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> Hi Masahiro,
>
> Thank you for your feedback!
> I am sorry that I haven't replied for so long.
>
> I agree with your point, based on this I would like
> to propose a second version of the patch.
>
> changes in v2:
> - Solution has changed from LBYL style to EAFP
>
> Best regards,
> Maciej Falkowski
> ---
> scripts/clang-tools/run-clang-tools.py | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/clang-tools/run-clang-tools.py b/scripts/clang-tools/run-clang-tools.py
> index fa7655c7cec0..27ebe2f2069a 100755
> --- a/scripts/clang-tools/run-clang-tools.py
> +++ b/scripts/clang-tools/run-clang-tools.py
> @@ -67,7 +67,14 @@ def main():
> # Read JSON data into the datastore variable
> with open(args.path, "r") as f:
> datastore = json.load(f)
> - pool.map(run_analysis, datastore)
> + try:
> + pool.map(run_analysis, datastore)
> + except FileNotFoundError as err:
> + if err.filename == 'clang-tidy':
> + print("Command 'clang-tidy' is missing in the system", file=sys.stderr)
> + sys.exit(127)
> + else:
> + raise err
>
>
> if __name__ == "__main__":
> --
> 2.26.3
prev parent reply other threads:[~2021-08-08 22:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 23:51 [PATCH] clang-tools: Print information when clang-tidy tool is missing Maciej Falkowski
2021-07-04 0:23 ` Nathan Chancellor
2021-07-05 16:18 ` Masahiro Yamada
2021-08-07 11:01 ` [PATCH v2] " Maciej Falkowski
2021-08-08 22:18 ` Nathan Chancellor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRBYHAJSpU5jcTQV@Ryzen-9-3900X.localdomain \
--to=nathan@kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.falkowski9@gmail.com \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=nhuck@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).