From: Thierry Reding <thierry.reding@gmail.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND 1/2] ARM: tegra: paz00: Handle device properties with software node API
Date: Tue, 17 Aug 2021 16:30:44 +0200 [thread overview]
Message-ID: <YRvIFJKmFlB6ntI5@orome.fritz.box> (raw)
In-Reply-To: <20210817102449.39994-2-heikki.krogerus@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1490 bytes --]
On Tue, Aug 17, 2021 at 01:24:48PM +0300, Heikki Krogerus wrote:
> The old device property API is going to be removed.
> Replacing the device_add_properties() call with the software
> node API equivalent, device_create_managed_software_node().
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> arch/arm/mach-tegra/board-paz00.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-tegra/board-paz00.c b/arch/arm/mach-tegra/board-paz00.c
> index b5c990a7a5af5..18d37f90cdfe3 100644
> --- a/arch/arm/mach-tegra/board-paz00.c
> +++ b/arch/arm/mach-tegra/board-paz00.c
> @@ -36,7 +36,7 @@ static struct gpiod_lookup_table wifi_gpio_lookup = {
>
> void __init tegra_paz00_wifikill_init(void)
> {
> - platform_device_add_properties(&wifi_rfkill_device, wifi_rfkill_prop);
> + device_create_managed_software_node(&wifi_rfkill_device.dev, wifi_rfkill_prop, NULL);
> gpiod_add_lookup_table(&wifi_gpio_lookup);
> platform_device_register(&wifi_rfkill_device);
> }
Seems alright. Looks to be doing mostly the same thing as the original
platform_device_add_properties() was doing, except for the node now
being managed, which is irrelevant in this context.
I'm fine with Greg picking this up. I'm not aware of any other changes
to this file that might cause a conflict for v5.15.
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-08-17 14:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 10:24 [PATCH RESEND 0/2] driver core: platform: Remove platform_device_add_properties() Heikki Krogerus
2021-08-17 10:24 ` [PATCH RESEND 1/2] ARM: tegra: paz00: Handle device properties with software node API Heikki Krogerus
2021-08-17 14:30 ` Thierry Reding [this message]
2021-08-18 10:57 ` Greg Kroah-Hartman
2021-08-17 10:24 ` [PATCH RESEND 2/2] driver core: platform: Remove platform_device_add_properties() Heikki Krogerus
2021-08-17 14:32 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRvIFJKmFlB6ntI5@orome.fritz.box \
--to=thierry.reding@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).