From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D6F3C4320E for ; Fri, 27 Aug 2021 02:11:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 536F860F39 for ; Fri, 27 Aug 2021 02:11:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244027AbhH0CMH (ORCPT ); Thu, 26 Aug 2021 22:12:07 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:44202 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241128AbhH0CMG (ORCPT ); Thu, 26 Aug 2021 22:12:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=CZAl2d77Ht15SARXwtHBnTj5q6I65Bl6hgGHiA77reA=; b=yWuP8aKLExX1fnPAlpWZ99iSk4 Vc2zyl1uK02K/oiZeuNM2Dh7XomQZQhnF8DZCWtWU4irRB2YduWXHefVEucdTPzzM7/usSbvh/4sn gbcBWiC/zAPKgG3vEHeSAB0XZ3DGRN6Jdb/5elDwTH3sFnTGNtt8iGcbp7+l0sRgPmwo=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mJRKp-0042gK-Do; Fri, 27 Aug 2021 04:11:11 +0200 Date: Fri, 27 Aug 2021 04:11:11 +0200 From: Andrew Lunn To: Joel Stanley Cc: "Gabriel L. Somlo" , Florent Kermarrec , "David S . Miller" , Jakub Kicinski , Rob Herring , Karol Gugala , Mateusz Holenko , devicetree , Networking , Linux Kernel Mailing List , David Shah , Stafford Horne Subject: Re: [PATCH v2 2/2] net: Add driver for LiteX's LiteEth network interface Message-ID: References: <20210820074726.2860425-3-joel@jms.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 25, 2021 at 06:35:17AM +0000, Joel Stanley wrote: > On Tue, 24 Aug 2021 at 19:43, Gabriel L. Somlo wrote: > > > > Hi Joel, > > > > Couple of comments below: > > > > On Fri, Aug 20, 2021 at 05:17:26PM +0930, Joel Stanley wrote: > > > > diff --git a/drivers/net/ethernet/litex/Kconfig b/drivers/net/ethernet/litex/Kconfig > > > new file mode 100644 > > > index 000000000000..265dba414b41 > > > --- /dev/null > > > +++ b/drivers/net/ethernet/litex/Kconfig > > > > + > > > +config LITEX_LITEETH > > > + tristate "LiteX Ethernet support" > > > > Mostly cosmetic, but should there be a "depends on LITEX" statement in here? > > No, there's as there is no dependency on the litex soc driver. Which is good, you will get more build coverage that way, it will be built of x86, arm, mips, etc... > > > Maybe also "select MII" and "select PHYLIB"? > > Again, there is no mii or phy code so the driver doesn't need these. Yet. At some point i expect you will need these, but you don't need them now. Andrew