From: Lee Jones <lee.jones@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] mfd: Add missing of_node_put for loop iteration
Date: Wed, 22 Sep 2021 14:08:09 +0100 [thread overview]
Message-ID: <YUsquTRvuf0UdtkN@google.com> (raw)
In-Reply-To: <57a78707-e01c-29a3-b899-8715aab6c6c4@canonical.com>
On Wed, 22 Sep 2021, Krzysztof Kozlowski wrote:
> On 28/05/2021 13:51, Krzysztof Kozlowski wrote:
> > Early exits from for_each_child_of_node() should decrement the
> > node reference counter. Reported by Coccinelle:
> >
> > drivers/mfd/mfd-core.c:197:2-24: WARNING:
> > Function "for_each_child_of_node" should have of_node_put() before goto around lines 209.
> >
> > Fixes: c94bb233a9fe ("mfd: Make MFD core code Device Tree and IRQ domain aware")
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> > ---
> > drivers/mfd/mfd-core.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
> > index 79f5c6a18815..684a011a6396 100644
> > --- a/drivers/mfd/mfd-core.c
> > +++ b/drivers/mfd/mfd-core.c
> > @@ -198,6 +198,7 @@ static int mfd_add_device(struct device *parent, int id,
> > if (of_device_is_compatible(np, cell->of_compatible)) {
> > /* Ignore 'disabled' devices error free */
> > if (!of_device_is_available(np)) {
> > + of_node_put(np);
> > ret = 0;
> > goto fail_alias;
> > }
> > @@ -205,6 +206,7 @@ static int mfd_add_device(struct device *parent, int id,
> > ret = mfd_match_of_node_to_dev(pdev, np, cell);
> > if (ret == -EAGAIN)
> > continue;
> > + of_node_put(np);
> > if (ret)
> > goto fail_alias;
> >
> >
>
> Dear Lee,
>
> This was already a resend. Any comments from your side?
Looks like the last batch was RFC.
These all slipped through the net.
Back on my review pile, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-09-22 13:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 11:51 [RESEND PATCH] mfd: Add missing of_node_put for loop iteration Krzysztof Kozlowski
2021-09-22 8:13 ` Krzysztof Kozlowski
2021-09-22 13:08 ` Lee Jones [this message]
2021-10-06 7:58 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUsquTRvuf0UdtkN@google.com \
--to=lee.jones@linaro.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).