From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Input: colibri-vf50-ts - Make use of the helper function devm_add_action_or_reset()
Date: Wed, 22 Sep 2021 21:39:01 -0700 [thread overview]
Message-ID: <YUwE5d3rf93UbIBj@google.com> (raw)
In-Reply-To: <20210922125212.95-1-caihuoqing@baidu.com>
Hi Cai,
On Wed, Sep 22, 2021 at 08:52:09PM +0800, Cai Huoqing wrote:
> The helper function devm_add_action_or_reset() will internally
> call devm_add_action(), and if devm_add_action() fails then it will
> execute the action mentioned and return the error code. So
> use devm_add_action_or_reset() instead of devm_add_action()
> to simplify the error handling, reduce the code.
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> drivers/input/touchscreen/colibri-vf50-ts.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/input/touchscreen/colibri-vf50-ts.c b/drivers/input/touchscreen/colibri-vf50-ts.c
> index aa829725ded7..1a1d8e70ec40 100644
> --- a/drivers/input/touchscreen/colibri-vf50-ts.c
> +++ b/drivers/input/touchscreen/colibri-vf50-ts.c
> @@ -271,9 +271,8 @@ static int vf50_ts_probe(struct platform_device *pdev)
> if (IS_ERR(channels))
> return PTR_ERR(channels);
>
> - error = devm_add_action(dev, vf50_ts_channel_release, channels);
> + error = devm_add_action_or_reset(dev, vf50_ts_channel_release, channels);
It looks like there is devm_iio_channel_get_all(), we should be using it
instead of installing a custom release action.
> if (error) {
> - iio_channel_release_all(channels);
> dev_err(dev, "Failed to register iio channel release action");
> return error;
> }
> --
> 2.25.1
>
Thanks.
--
Dmitry
prev parent reply other threads:[~2021-09-23 4:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 12:52 [PATCH 1/3] Input: colibri-vf50-ts - Make use of the helper function devm_add_action_or_reset() Cai Huoqing
2021-09-22 12:52 ` [PATCH 2/3] Input: elants_i2c " Cai Huoqing
2021-09-23 4:49 ` Dmitry Torokhov
2021-09-22 12:52 ` [PATCH 3/3] Input: raydium_i2c_ts " Cai Huoqing
2021-09-23 4:49 ` Dmitry Torokhov
2021-09-23 4:39 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUwE5d3rf93UbIBj@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=caihuoqing@baidu.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).