From: Mark Brown <broonie@kernel.org>
To: Luca Weiss <luca@z3ntu.xyz>
Cc: linux-arm-msm@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/11] regulator: qcom-rpmh: Add PM6350 regulators
Date: Mon, 4 Oct 2021 22:18:59 +0100 [thread overview]
Message-ID: <YVtvwy4egA3sEgBy@sirena.org.uk> (raw)
In-Reply-To: <4777503.XO8xY86g4A@g550jk>
[-- Attachment #1: Type: text/plain, Size: 1120 bytes --]
On Mon, Oct 04, 2021 at 10:44:25PM +0200, Luca Weiss wrote:
> On Montag, 4. Oktober 2021 14:37:31 CEST Mark Brown wrote:
> > If you don't know don't fix it into ABI, just don't specify anything
> > until someone figures out something accurate to put in there.
> The RPMH_VREG macro expects _supply_name so what should I put there instead?
NULL should do the right thing, or make a new macro.
> > > Additionally leave out configuration of smps3 - smps5 and ldo17 as these
> > > are not configured in the downstream kernel.
> > Just describe everything that's there - nothing will get touched if the
> > board doesn't explicitly enable doing so, otherwise everything is read
> > only.
> Problem is I do not know which types those regulators are, e.g. pldo or nldo.
> The ones I described are experimentally verified because the wrong configuration
> makes the driver probe fail.
> So I can't really put anything there, unless there's another way to do this.
That makes sense, please explain in the commit log that only are they
not initialized but also you don't know what types they are.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-10-04 21:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 8:31 [PATCH 00/11] Initial Fairphone 4 support Luca Weiss
2021-10-03 8:31 ` [PATCH 01/11] clk: qcom: add select QCOM_GDSC for SM6350 Luca Weiss
2021-10-03 11:21 ` Konrad Dybcio
2021-10-03 8:31 ` [PATCH 02/11] dt-bindings: regulator: qcom,rpmh: Add compatible for PM6350 Luca Weiss
2021-10-03 8:31 ` [PATCH 03/11] regulator: qcom-rpmh: Add PM6350 regulators Luca Weiss
2021-10-04 12:37 ` Mark Brown
2021-10-04 20:44 ` Luca Weiss
2021-10-04 21:18 ` Mark Brown [this message]
2021-10-03 8:31 ` [PATCH 04/11] dt-bindings: pinctrl: qcom,pmic-gpio: Add compatible for PM6350 Luca Weiss
2021-10-03 8:31 ` [PATCH 05/11] pinctrl: qcom: spmi-gpio: " Luca Weiss
2021-10-03 8:31 ` [PATCH 06/11] arm64: dts: qcom: Add PM6350 PMIC Luca Weiss
2021-10-03 11:23 ` Konrad Dybcio
2021-10-03 8:31 ` [PATCH 07/11] arm64: dts: qcom: sm6350: add debug uart Luca Weiss
2021-10-03 8:31 ` [PATCH 08/11] dt-bindings: arm: cpus: Add Kryo 570 CPUs Luca Weiss
2021-10-03 8:31 ` [PATCH 09/11] dt-bindings: arm: qcom: Document sm7225 and fairphone,fp4 board Luca Weiss
2021-10-03 8:31 ` [PATCH 10/11] arm64: dts: qcom: Add SM7225 device tree Luca Weiss
2021-10-03 11:32 ` Konrad Dybcio
2021-10-03 8:31 ` [PATCH 11/11] arm64: dts: qcom: sm7225: Add device tree for Fairphone 4 Luca Weiss
2021-10-03 11:35 ` Konrad Dybcio
2021-10-31 22:10 ` [PATCH 00/11] Initial Fairphone 4 support Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVtvwy4egA3sEgBy@sirena.org.uk \
--to=broonie@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).