From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Kent Gibson <warthog618@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Shuah Khan <shuah@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v13 3/7] gpiolib: of: make fwnode take precedence in struct gpio_chip
Date: Tue, 7 Dec 2021 14:24:57 +0200 [thread overview]
Message-ID: <Ya9SmcbJdHMnvg0y@smile.fi.intel.com> (raw)
In-Reply-To: <20211207093412.27833-4-brgl@bgdev.pl>
On Tue, Dec 07, 2021 at 10:34:08AM +0100, Bartosz Golaszewski wrote:
> If the driver sets the fwnode in struct gpio_chip, let it take
> precedence over the of_node. This only affects OF-based systems,
> ACPI needs to be converted separately.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thanks!
> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
> ---
> drivers/gpio/gpiolib-of.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
> index 0ad288ab6262..91dcf2c6cdd8 100644
> --- a/drivers/gpio/gpiolib-of.c
> +++ b/drivers/gpio/gpiolib-of.c
> @@ -1046,6 +1046,9 @@ void of_gpio_dev_init(struct gpio_chip *gc, struct gpio_device *gdev)
> if (gc->parent)
> gdev->dev.of_node = gc->parent->of_node;
>
> + if (gc->fwnode)
> + gc->of_node = to_of_node(gc->fwnode);
> +
> /* If the gpiochip has an assigned OF node this takes precedence */
> if (gc->of_node)
> gdev->dev.of_node = gc->of_node;
> --
> 2.25.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-12-07 12:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 9:34 [PATCH v13 0/7] gpio-sim: configfs-based GPIO simulator Bartosz Golaszewski
2021-12-07 9:34 ` [PATCH v13 1/7] gpiolib: provide gpiod_remove_hogs() Bartosz Golaszewski
2021-12-07 9:34 ` [PATCH v13 2/7] gpiolib: allow to specify the firmware node in struct gpio_chip Bartosz Golaszewski
2021-12-07 12:24 ` Andy Shevchenko
2021-12-07 9:34 ` [PATCH v13 3/7] gpiolib: of: make fwnode take precedence " Bartosz Golaszewski
2021-12-07 12:24 ` Andy Shevchenko [this message]
2021-12-07 9:34 ` [PATCH v13 4/7] gpio: sim: new testing module Bartosz Golaszewski
2021-12-07 13:58 ` Andy Shevchenko
2021-12-07 9:34 ` [PATCH v13 5/7] selftests: gpio: provide a helper for reading chip info Bartosz Golaszewski
2021-12-07 9:34 ` [PATCH v13 6/7] selftests: gpio: add a helper for reading GPIO line names Bartosz Golaszewski
2021-12-07 9:34 ` [PATCH v13 7/7] selftests: gpio: add test cases for gpio-sim Bartosz Golaszewski
2021-12-09 0:54 ` [PATCH v13 0/7] gpio-sim: configfs-based GPIO simulator Linus Walleij
2021-12-10 19:08 ` Bartosz Golaszewski
2021-12-13 13:01 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya9SmcbJdHMnvg0y@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=geert@linux-m68k.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).