From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] tracing: Account bottom half disabled sections.
Date: Mon, 13 Dec 2021 10:28:14 +0100 [thread overview]
Message-ID: <YbcSLmrm0HmCJzvJ@linutronix.de> (raw)
In-Reply-To: <20211210203240.43a8e7eb@gandalf.local.home>
On 2021-12-10 20:32:40 [-0500], Steven Rostedt wrote:
> > @@ -4226,7 +4228,7 @@ static void print_func_help_header_irq(struct array_buffer *buf, struct seq_file
> >
> > seq_printf(m, "# %.*s _-----=> irqs-off\n", prec, space);
> > seq_printf(m, "# %.*s / _----=> need-resched\n", prec, space);
> > - seq_printf(m, "# %.*s| / _---=> hardirq/softirq\n", prec, space);
> > + seq_printf(m, "# %.*s| / _---=> hardirq/softirq/BH-disabled\n", prec, space);
>
> So I went to update the documentation on this, and realized that this is
> wrong. Really, we want this in the irqs-off section probably.
>
> Note, the above is to show we are running in a hardirq or softirq context.
> But BH-disabled does not match that. Should this be with irqs-off being:
>
> d - irqs are disabled
> b - BH is disabled?
> D - irqs and BH is disabled?
We are not in hardirq/softirq/nmi but have simply BH disabled.
Makes sense.
> -- Steve
Sebastian
next prev parent reply other threads:[~2021-12-13 9:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 20:31 [PATCH] tracing: Account bottom half disabled sections Sebastian Andrzej Siewior
2021-12-11 1:32 ` Steven Rostedt
2021-12-13 9:28 ` Sebastian Andrzej Siewior [this message]
2021-12-13 10:08 ` [PATCH v2] " Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbcSLmrm0HmCJzvJ@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).