linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: Sergey Shtylyov <s.shtylyov@omp.ru>,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
	Hans de Goede <hdegoede@redhat.com>, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved
Date: Tue, 14 Dec 2021 00:02:48 +0200	[thread overview]
Message-ID: <YbfDCNIMNy4PdBwL@smile.fi.intel.com> (raw)
In-Reply-To: <0d967bb4-0b80-c293-b7d5-f49c9cc38718@opensource.wdc.com>

On Tue, Dec 14, 2021 at 06:36:00AM +0900, Damien Le Moal wrote:
> On 2021/12/13 20:52, Andy Shevchenko wrote:
> > On Mon, Dec 13, 2021 at 07:39:31AM +0900, Damien Le Moal wrote:
> >> On 2021/12/11 19:25, Sergey Shtylyov wrote:

...

> >> The problem I see is that the current behavior is unclear: what does
> >> platform_get_irq_optional() returning 0 mean ? IRQ == 0 ? or "no IRQ" ? I think
> >> it should be the latter rather than the former. Note that the function could
> >> return ENOENT (or similar) for the "no IRQ" case. With that, case (2) goes away,
> >> but then I do not see any difference between platform_get_irq_optional() and
> >> platform_get_irq().
> >>
> >> If the preferred API semantic is to allow returning IRQ 0 with a warning, then
> >> the kdoc comments of platform_get_irq_optional() and platform_get_irq() are
> >> totally broken, and the code for many drivers is probably wrong too.
> > 
> > Yeah, what we need to do is that (roughly a roadmap):
> >  - revisit callers of platform_get_irq_optional() to be prepared for
> >    new behaviour
> >  - rewrite platform_get_irq() to return -ENOENT
> >  - rewrite platform_get_irq_optional() to return 0 on -ENOENT
> > 
> > This is how other similar (i.e. _optional) APIs do.
> 
> Sounds like a good plan to me. In the mean time though, your patch 1/2 should
> keep the "if (!irq)" test and return an error for that case. No ?

No problem. I can send a v2.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2021-12-13 22:03 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-09 14:59 [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved Andy Shevchenko
2021-12-09 14:59 ` [PATCH v1 2/2] ata: libahci_platform: Remove bogus 32-bit DMA mask attempt Andy Shevchenko
2021-12-10 19:34   ` Andy Shevchenko
2021-12-11  0:04     ` Damien Le Moal
2021-12-17  0:58   ` Damien Le Moal
2021-12-17 11:57     ` Andy Shevchenko
2021-12-09 15:21 ` [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved Hans de Goede
2021-12-09 17:24 ` Sergey Shtylyov
2021-12-09 17:42   ` Andy Shevchenko
2021-12-09 18:22     ` Sergey Shtylyov
2021-12-09 19:22       ` Andy Shevchenko
2021-12-09 19:27         ` Andy Shevchenko
2021-12-09 20:31           ` Sergey Shtylyov
2021-12-09 20:29         ` Sergey Shtylyov
2021-12-10 10:44           ` Andy Shevchenko
2021-12-10 11:14             ` Sergey Shtylyov
2021-12-10 11:28               ` Andy Shevchenko
2021-12-10 17:39                 ` Sergey Shtylyov
2021-12-10 17:51                   ` Andy Shevchenko
2021-12-09 22:49 ` Damien Le Moal
2021-12-09 22:57   ` Damien Le Moal
2021-12-10  8:47   ` Andy Shevchenko
2021-12-10 16:38     ` Sergey Shtylyov
2021-12-10 17:57       ` Andy Shevchenko
2021-12-10  8:59   ` Sergey Shtylyov
2021-12-10 10:46     ` Andy Shevchenko
2021-12-10 11:19       ` Sergey Shtylyov
2021-12-10 11:36         ` Andy Shevchenko
2021-12-10 17:15           ` Sergei Shtylyov
2021-12-10 17:59             ` Andy Shevchenko
2021-12-10 19:01               ` Sergey Shtylyov
2021-12-10 19:25                 ` Andy Shevchenko
2021-12-10 19:30                   ` Sergey Shtylyov
2021-12-10 19:35                     ` Sergei Shtylyov
2021-12-11 10:13                       ` Sergey Shtylyov
2021-12-13 11:26                         ` Andy Shevchenko
2021-12-10 23:45     ` Damien Le Moal
2021-12-11 10:25       ` Sergey Shtylyov
2021-12-12 22:39         ` Damien Le Moal
2021-12-13 11:52           ` Andy Shevchenko
2021-12-13 21:36             ` Damien Le Moal
2021-12-13 22:02               ` Andy Shevchenko [this message]
2021-12-13 11:49         ` Andy Shevchenko
2021-12-13 11:46       ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YbfDCNIMNy4PdBwL@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=axboe@kernel.dk \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=s.shtylyov@omp.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).