From: Vincent Donnefort <vincent.donnefort@arm.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: peterz@infradead.org, mingo@redhat.com,
linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com,
Valentin.Schneider@arm.com, Morten.Rasmussen@arm.com,
qperret@google.com
Subject: Re: [PATCH 2/3] sched/fair: Fix newidle_balance() for overutilized systems
Date: Mon, 10 Jan 2022 16:29:19 +0000 [thread overview]
Message-ID: <YdxeoRUeZhl2D+dK@FVFF7649Q05P> (raw)
In-Reply-To: <CAKfTPtCJPHfoiuspYMGPARHdOuLJ6g0oUx2EQjdEPz729NrDPA@mail.gmail.com>
[...]
>
> > can spuriously maintain overutilized for a long period of time.
> >
> > We then need newidle_balance() to proceed with balancing if the system is
> > overutilized.
>
> Always triggering a costly newidle_balance when you are already
> overutilized for the sole purpose of clearing overutilized seems to be
> a bit overkill.
But the only cases where newidle_balance() would now run while it used not to,
are when overutilized is set but overload is not. Which is either a transient
state for which we do not anticipate more than one stat update or it is the
situation where one of the biggest CPU is overutilized while having nr_running <
2.
It can indeed add some additional costly calls to newidle_balance, but they
will not be plentiful, especially with the other patch from this series:
"sched/fair: Do not raise overutilized for idle CPUs"
>
> Furthermore, nothing prevents us to abort newidle_balance before
> reaching the root domain
should_we_balance() always return true in the case of newidle. So I suppose you
refer to max_newidle_lb_cost?
>
> So this doesn't seem like the good way to proceed
What are our other options?
Resolving it in the nohz balancer would need to change should_we_balance().
I also tried solely to not raise overutilized when the CPU is idle but this is
not a solution either as when a task migration is pending, you can end-up with
a !idle CPU but with nr_running < 2, so once again overutilized set, overload
not.
>
> >
> > Fixes: 2802bf3cd936 ("sched/fair: Add over-utilization/tipping point indicator")
> > Signed-off-by: Vincent Donnefort <vincent.donnefort@arm.com>
> >
> > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> > index e2f6fa14e5e7..51f6f55abb37 100644
> > --- a/kernel/sched/fair.c
> > +++ b/kernel/sched/fair.c
> > @@ -10849,7 +10849,8 @@ static int newidle_balance(struct rq *this_rq, struct rq_flags *rf)
> > rcu_read_lock();
> > sd = rcu_dereference_check_sched_domain(this_rq->sd);
> >
> > - if (!READ_ONCE(this_rq->rd->overload) ||
> > + if ((!READ_ONCE(this_rq->rd->overload) &&
> > + !READ_ONCE(this_rq->rd->overutilized)) ||
> > (sd && this_rq->avg_idle < sd->max_newidle_lb_cost)) {
> >
> > if (sd)
> > --
> > 2.25.1
> >
next prev parent reply other threads:[~2022-01-10 16:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 11:43 [PATCH 0/3] Fix stuck overutilized Vincent Donnefort
2021-12-20 11:43 ` [PATCH 1/3] sched/fair: Make cpu_overutilized() EAS dependent Vincent Donnefort
2021-12-20 17:17 ` Valentin Schneider
2021-12-21 9:09 ` Vincent Donnefort
2021-12-20 11:43 ` [PATCH 2/3] sched/fair: Fix newidle_balance() for overutilized systems Vincent Donnefort
2021-12-20 17:17 ` Valentin Schneider
2021-12-22 8:14 ` Vincent Guittot
2022-01-10 16:29 ` Vincent Donnefort [this message]
2021-12-20 11:43 ` [PATCH 3/3] sched/fair: Do not raise overutilized for idle CPUs Vincent Donnefort
2021-12-20 17:17 ` Valentin Schneider
2021-12-22 8:20 ` Vincent Guittot
2022-01-10 16:40 ` Vincent Donnefort
2022-01-17 10:45 ` Vincent Guittot
2022-01-17 12:18 ` Vincent Donnefort
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdxeoRUeZhl2D+dK@FVFF7649Q05P \
--to=vincent.donnefort@arm.com \
--cc=Morten.Rasmussen@arm.com \
--cc=Valentin.Schneider@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).