From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 018DEC433F5 for ; Wed, 16 Feb 2022 15:28:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234137AbiBPP3I (ORCPT ); Wed, 16 Feb 2022 10:29:08 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:60886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234004AbiBPP3D (ORCPT ); Wed, 16 Feb 2022 10:29:03 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8608219DE8D; Wed, 16 Feb 2022 07:28:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=R6kAipwXMO7TbFMaTolYaEj+jLUzE9dE71Ig4CplYiA=; b=oQJrr7uONSRmx7FuSCPg0hA4l1 BLJjdDhri53590/Hgz93mObhi3Vli+4mMqaw+Wp9OcR0wION2EbJObpe0w/BhcrYAxWLQRkFCv7aD wFPU1/O5o8+pqHh0yTnQLngrwIstx+xabfOQagn1pDzITFYaTHQIzk3iVfMHAs/lkSFdnOwagDJ+e RlID2cWv2Q8umUbV77NATcj/iPuZTTeXMLLG0ezi/TKsMogcaN42f7dh6LxotlxE65NUFQ+7UQasw lpJwOmLF4aWjj39H82Qs63j9WbJnmYIdwirt2a1yFFYJni5XaGXDMzUzvrL5oU75n2GpzObz6cGeE 83FJyeBA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKMEG-007Uuo-K5; Wed, 16 Feb 2022 15:28:28 +0000 Date: Wed, 16 Feb 2022 07:28:28 -0800 From: Christoph Hellwig To: "Maciej W. Rozycki" Cc: Christoph Hellwig , Sudip Mukherjee , Catalin Marinas , Will Deacon , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Alexander Gordeev , Sven Schnelle , Jeff Dike , Richard Weinberger , Anton Ivanov , Chris Zankel , Max Filippov , linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] parport_pc: Also enable driver for PCI systems Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 15, 2022 at 09:11:45AM +0000, Maciej W. Rozycki wrote: > On Mon, 14 Feb 2022, Christoph Hellwig wrote: > > > > =================================================================== > > > --- linux-macro.orig/arch/arm64/include/asm/Kbuild > > > +++ linux-macro/arch/arm64/include/asm/Kbuild > > > @@ -3,6 +3,7 @@ generic-y += early_ioremap.h > > > generic-y += mcs_spinlock.h > > > generic-y += qrwlock.h > > > generic-y += qspinlock.h > > > +generic-y += parport.h > > > > Instead of adding generic-y just ad a mandatory-y in > > include/asm-generic/Kbuild. > > I'm inconvinced. Not all archs want it, 5 don't. Which is exactly what mandatory-y is for. Provide the asm-generic version by default, but let architectures override it.