From: Rob Herring <robh@kernel.org>
To: Ansuel Smith <ansuelsmth@gmail.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH v5 15/18] dt-bindings: clock: Add L2 clocks to qcom,krait-cc Documentation
Date: Mon, 21 Mar 2022 16:50:59 -0500 [thread overview]
Message-ID: <YjjzQw4z6GCmlmp+@robh.at.kernel.org> (raw)
In-Reply-To: <20220321153855.12082-16-ansuelsmth@gmail.com>
On Mon, Mar 21, 2022 at 04:38:52PM +0100, Ansuel Smith wrote:
> Krait-cc qcom driver provide also L2 clocks and require the acpu_l2_aux
> and the hfpll_l2 clock to be provided. Add these missing clocks to the
> Documentation. The driver keep support for both old and this new
> implementation and should prevent any regression by this fixup.
Depends on what the old driver looks for.
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> .../devicetree/bindings/clock/qcom,krait-cc.yaml | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,krait-cc.yaml b/Documentation/devicetree/bindings/clock/qcom,krait-cc.yaml
> index e879bfbe67ac..f89b70ab01ae 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,krait-cc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,krait-cc.yaml
> @@ -23,16 +23,20 @@ properties:
> items:
> - description: phandle to hfpll for CPU0 mux
> - description: phandle to hfpll for CPU1 mux
> + - description: phandle to hfpll for L2 mux
> - description: phandle to CPU0 aux clock
> - description: phandle to CPU1 aux clock
> + - description: phandle to L2 aux clock
> - description: phandle to QSB fixed clk
Clock indices should not change. New clocks go on the end of the list.
>
> clock-names:
> items:
> - const: hfpll0
> - const: hfpll1
> + - const: hfpll_l2
> - const: acpu0_aux
> - const: acpu1_aux
> + - const: acpu_l2_aux
> - const: qsb
>
> '#clock-cells':
> @@ -50,10 +54,10 @@ examples:
> - |
> clock-controller {
> compatible = "qcom,krait-cc-v1";
> - clocks = <&hfpll0>, <&hfpll1>,
> - <&acpu0_aux>, <&acpu1_aux>, <&qsb>;
> - clock-names = "hfpll0", "hfpll1",
> - "acpu0_aux", "acpu1_aux", "qsb";
> + clocks = <&hfpll0>, <&hfpll1>, <&hfpll_l2>,
> + <&acpu0_aux>, <&acpu1_aux>, <&acpu_l2_aux>, <&qsb>;
> + clock-names = "hfpll0", "hfpll1", "hfpll_l2",
> + "acpu0_aux", "acpu1_aux", "acpu_l2_aux", "qsb";
> #clock-cells = <1>;
> };
> ...
> --
> 2.34.1
>
>
next prev parent reply other threads:[~2022-03-21 22:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 15:38 [PATCH v5 00/18] Modernize rest of the krait drivers Ansuel Smith
2022-03-21 15:38 ` [PATCH v5 01/18] clk: introduce clk_hw_get_index_of_parent new API Ansuel Smith
2022-03-21 15:38 ` [PATCH v5 02/18] clk: qcom: gcc-ipq806x: skip pxo/cxo fixed clk if already present Ansuel Smith
2022-03-21 15:38 ` [PATCH v5 03/18] clk: qcom: gcc-ipq806x: add PXO_SRC in clk table Ansuel Smith
2022-03-21 15:38 ` [PATCH v5 04/18] clk: qcom: clk-hfpll: use poll_timeout macro Ansuel Smith
2022-03-21 15:38 ` [PATCH v5 05/18] clk: qcom: kpss-xcc: convert to parent data API Ansuel Smith
2022-03-21 15:38 ` [PATCH v5 06/18] clk: qcom: clk-krait: unlock spin after mux completion Ansuel Smith
2022-03-21 15:38 ` [PATCH v5 07/18] clk: qcom: clk-krait: add hw_parent check for div2_round_rate Ansuel Smith
2022-03-21 15:38 ` [PATCH v5 08/18] clk: qcom: krait-cc: convert to parent_data API Ansuel Smith
2022-03-21 15:38 ` [PATCH v5 09/18] clk: qcom: krait-cc: drop pr_info and register qsb only if needed Ansuel Smith
2022-03-21 15:38 ` [PATCH v5 10/18] clk: qcom: krait-cc: drop hardcoded safe_sel Ansuel Smith
2022-03-21 15:38 ` [PATCH v5 11/18] clk: qcom: krait-cc: force sec_mux to QSB Ansuel Smith
2022-03-21 15:38 ` [PATCH v5 12/18] clk: qcom: clk-krait: add apq/ipq8064 errata workaround Ansuel Smith
2022-03-21 15:38 ` [PATCH v5 13/18] clk: qcom: clk-krait: add enable disable ops Ansuel Smith
2022-03-21 15:38 ` [PATCH v5 14/18] dt-bindings: clock: Convert qcom,krait-cc to yaml Ansuel Smith
2022-03-21 21:51 ` Rob Herring
2022-03-21 15:38 ` [PATCH v5 15/18] dt-bindings: clock: Add L2 clocks to qcom,krait-cc Documentation Ansuel Smith
2022-03-21 21:50 ` Rob Herring [this message]
2022-03-21 21:31 ` Ansuel Smith
2022-03-21 15:38 ` [PATCH v5 16/18] ARM: dts: qcom: qcom-ipq8064: add missing krait-cc compatible and clocks Ansuel Smith
2022-03-21 15:38 ` [PATCH v5 17/18] dt-bindings: arm: msm: Convert kpss-acc driver Documentation to yaml Ansuel Smith
2022-03-21 15:38 ` [PATCH v5 18/18] dt-bindings: arm: msm: Convert kpss-gcc " Ansuel Smith
2022-03-21 19:18 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjjzQw4z6GCmlmp+@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).