From: Liam Beguin <liambeguin@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Peter Rosin <peda@axentia.se>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH v1 1/1] iio: afe: rescale: Make use of device properties
Date: Thu, 14 Apr 2022 10:32:38 -0400 [thread overview]
Message-ID: <Ylgwhu9zdmwwYnAq@shaak> (raw)
In-Reply-To: <20220413190117.29814-1-andriy.shevchenko@linux.intel.com>
Hi Andy,
On Wed, Apr 13, 2022 at 10:01:17PM +0300, Andy Shevchenko wrote:
> Convert the module to be property provider agnostic and allow
> it to be used on non-OF platforms.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/iio/afe/Kconfig | 1 -
> drivers/iio/afe/iio-rescale.c | 5 ++---
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/afe/Kconfig b/drivers/iio/afe/Kconfig
> index 4fa397822cff..9a1d95c1c7ed 100644
> --- a/drivers/iio/afe/Kconfig
> +++ b/drivers/iio/afe/Kconfig
> @@ -8,7 +8,6 @@ menu "Analog Front Ends"
>
> config IIO_RESCALE
> tristate "IIO rescale"
> - depends on OF || COMPILE_TEST
> help
> Say yes here to build support for the IIO rescaling
> that handles voltage dividers, current sense shunts and
> diff --git a/drivers/iio/afe/iio-rescale.c b/drivers/iio/afe/iio-rescale.c
> index 7e511293d6d1..c6cf709f0f05 100644
> --- a/drivers/iio/afe/iio-rescale.c
> +++ b/drivers/iio/afe/iio-rescale.c
> @@ -10,9 +10,8 @@
>
> #include <linux/err.h>
> #include <linux/gcd.h>
> +#include <linux/mod_devicetable.h>
Is this really needed?
device_get_match_data() is already defined in <linux/property.h>
Cheers,
Liam
> #include <linux/module.h>
> -#include <linux/of.h>
> -#include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/property.h>
>
> @@ -536,7 +535,7 @@ static int rescale_probe(struct platform_device *pdev)
>
> rescale = iio_priv(indio_dev);
>
> - rescale->cfg = of_device_get_match_data(dev);
> + rescale->cfg = device_get_match_data(dev);
> rescale->numerator = 1;
> rescale->denominator = 1;
> rescale->offset = 0;
> --
> 2.35.1
>
next prev parent reply other threads:[~2022-04-14 15:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 19:01 [PATCH v1 1/1] iio: afe: rescale: Make use of device properties Andy Shevchenko
2022-04-14 14:32 ` Liam Beguin [this message]
2022-04-14 17:03 ` Andy Shevchenko
2022-04-15 14:47 ` Liam Beguin
2022-04-16 10:41 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ylgwhu9zdmwwYnAq@shaak \
--to=liambeguin@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).