From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Cc: Theodore Ts'o <tytso@mit.edu>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Steven Rostedt <rostedt@goodmis.org>,
Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH RFC v1] random: use static branch for crng_ready()
Date: Wed, 11 May 2022 13:41:27 +0200 [thread overview]
Message-ID: <Ynug580srdedsiY9@zx2c4.com> (raw)
In-Reply-To: <20220503134052.646325-1-Jason@zx2c4.com>
On Tue, May 03, 2022 at 03:40:52PM +0200, Jason A. Donenfeld wrote:
> +static bool crng_ready_slowpath(void)
> +{
> + if (crng_init <= 1)
> + return false;
> + if (in_atomic() || irqs_disabled() || cmpxchg(&crng_init, 2, 3) != 2)
> + return true;
Nobody chimed in here, but for posterity I thought I should point out
that this approach actually won't work, since in_atomic() doesn't work
with CONFIG_PREEMPT_COUNT=n kernels.
So back to the drawing board in trying to figure out the best way to do
this...
Jason
next prev parent reply other threads:[~2022-05-11 11:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 13:40 [PATCH RFC v1] random: use static branch for crng_ready() Jason A. Donenfeld
2022-05-11 11:41 ` Jason A. Donenfeld [this message]
2022-05-12 4:35 ` Herbert Xu
2022-05-12 11:18 ` Jason A. Donenfeld
2022-05-12 12:22 ` [PATCH v2] " Jason A. Donenfeld
2022-05-12 14:42 ` [PATCH v3] " Jason A. Donenfeld
2022-05-12 16:37 ` [PATCH v4] " Jason A. Donenfeld
2022-05-13 6:22 ` Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ynug580srdedsiY9@zx2c4.com \
--to=jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=rostedt@goodmis.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).