From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Phil Elwell <phil@raspberrypi.com>
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>,
Russell King <rmk+kernel@armlinux.org.uk>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Stephen Boyd <swboyd@chromium.org>,
Ard Biesheuvel <ardb@kernel.org>, stable <stable@vger.kernel.org>
Subject: Re: [PATCH v2] ARM: initialize jump labels before setup_machine_fdt()
Date: Tue, 7 Jun 2022 17:14:59 +0200 [thread overview]
Message-ID: <Yp9rc1G6xfTSSUjF@zx2c4.com> (raw)
In-Reply-To: <8c3fe744-0181-043a-3af9-dd00165a6356@raspberrypi.com>
Hey again,
On Tue, Jun 07, 2022 at 10:15:27AM +0100, Phil Elwell wrote:
> On 07/06/2022 09:43, Jason A. Donenfeld wrote:
> > Hi Phil,
> >
> > On Tue, Jun 7, 2022 at 10:29 AM Phil Elwell <phil@raspberrypi.com> wrote:
> >>
> >> This patch is fatal for me in the downstream Raspberry Pi kernel - it locks up
> >> on boot even before the earlycon output is available. Hacking jump_label_init to
> >> skip the jump_entry for "crng_is_ready" allows it to boot, but is likely to have
> >> consequences further down the line.
> >
> > Also, reading this a few times, I'm not 100% sure I understand what
> > you did to hack around this and why that works. Think you could paste
> > your hackpatch just out of interest to the discussion (but obviously
> > not to be applied)?
>
> This is the minimal version of my workaround patch that at least allows the
> board to boot. Bear in mind that it was written with no previous knowledge of
> jump labels and was arrived at by iteratively bisecting the list of jump_labels
> until the first dangerous one was found, then later working out that there was
> only one.
Looks like this patch fails due to CONFIG_STRICT_KERNEL_RWX.
Investigating deeper now, but that for starters seems to be the
differentiating factor between my prior test rig and one that reproduces
the error. I assume your raspi also sets CONFIG_STRICT_KERNEL_RWX.
Jason
next prev parent reply other threads:[~2022-06-07 15:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 8:29 [PATCH v2] ARM: initialize jump labels before setup_machine_fdt() Phil Elwell
2022-06-07 8:30 ` Jason A. Donenfeld
2022-06-07 8:47 ` Phil Elwell
2022-06-07 8:51 ` Jason A. Donenfeld
2022-06-07 10:06 ` Catalin Marinas
2022-06-07 10:11 ` Jason A. Donenfeld
2022-06-08 8:20 ` Jason A. Donenfeld
2022-06-08 9:16 ` Catalin Marinas
2022-06-07 9:10 ` Greg KH
2022-06-07 11:04 ` Phil Elwell
2022-06-07 11:09 ` Jason A. Donenfeld
2022-06-07 9:14 ` Russell King (Oracle)
2022-06-07 9:16 ` Jason A. Donenfeld
2022-06-07 8:43 ` Jason A. Donenfeld
2022-06-07 9:15 ` Phil Elwell
2022-06-07 15:14 ` Jason A. Donenfeld [this message]
2022-06-07 15:35 ` Phil Elwell
2022-06-07 15:44 ` Jason A. Donenfeld
2022-06-07 15:51 ` Phil Elwell
2022-06-07 19:30 ` [PATCH v3] " Jason A. Donenfeld
2022-06-08 8:18 ` Jason A. Donenfeld
-- strict thread matches above, loose matches on Subject: below --
2022-06-03 12:15 [PATCH v2] " Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yp9rc1G6xfTSSUjF@zx2c4.com \
--to=jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=phil@raspberrypi.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=stable@vger.kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).