From: Borislav Petkov <bp@alien8.de>
To: Ingo Molnar <mingo@kernel.org>
Cc: X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [RFC PATCH 2/3] x86/microcode: Default-disable late loading
Date: Fri, 27 May 2022 12:58:18 +0200 [thread overview]
Message-ID: <YpCuyrqc/YEmdPs6@zn.tnic> (raw)
In-Reply-To: <YpCp5B7noKAt+91A@gmail.com>
On Fri, May 27, 2022 at 12:37:24PM +0200, Ingo Molnar wrote:
> Might make sense to outline here valid circumstances under which late
> loading is used? Such as some weird kernel package that doesn't have the
> latest firmware included in the initrd?
Well, considering how we do correctness first, functionality later, I'd
really really like to not do late loading at all.
I wasn't aware of this sequence Cooper gave me on IRC but consider what
happens where one thread is doing the microcode uploading and the other
gets an NMI!
Our "precious" dance we have right now is not protected against that
scenario so *actually*, if we have to do the right thing, we should not
do late loading at all and zap it.
> Because it's hard (for me) to see any valid circumstance under which late
> loading should be supported at all TBH: new kernels where this patch is
> active would come with a modern package.
>
> Ie. we should consider removing late loading altogether.
Yap, exactly.
Late loading is actually broken as it is right now, IMNSVHO.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-05-27 10:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 18:53 [RFC PATCH 0/3] x86/microcode: Drop old interface and default-disable late loading Borislav Petkov
2022-05-24 18:53 ` [RFC PATCH 1/3] x86/microcode: Rip out the OLD_INTERFACE Borislav Petkov
2022-05-24 18:53 ` [RFC PATCH 2/3] x86/microcode: Default-disable late loading Borislav Petkov
2022-05-27 10:37 ` Ingo Molnar
2022-05-27 10:58 ` Borislav Petkov [this message]
2022-05-24 18:53 ` [RFC PATCH 3/3] x86/microcode: Taint and warn on " Borislav Petkov
2022-05-25 1:03 ` Luck, Tony
2022-05-25 6:59 ` Peter Zijlstra
2022-05-25 7:37 ` Borislav Petkov
2022-05-25 14:50 ` Luck, Tony
2022-05-25 15:28 ` Borislav Petkov
2022-05-25 15:40 ` Luck, Tony
2022-05-25 16:00 ` Borislav Petkov
2022-05-26 12:11 ` Taint addresses Borislav Petkov
2022-05-26 16:41 ` Luck, Tony
2022-05-27 9:45 ` Borislav Petkov
2022-05-25 10:03 ` [RFC PATCH 3/3] x86/microcode: Taint and warn on late loading Peter Zijlstra
2022-05-25 12:52 ` [RFC PATCH -v2] " Borislav Petkov
2022-05-25 13:55 ` [PATCH 4/3] x86/microcode: Remove unnecessary perf callback default-disable " Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YpCuyrqc/YEmdPs6@zn.tnic \
--to=bp@alien8.de \
--cc=andrew.cooper3@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).