From: Christoph Hellwig <hch@infradead.org>
To: Keir Fraser <keirf@google.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
kernel-team@android.com,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio: Force DMA restricted devices through DMA API
Date: Tue, 19 Jul 2022 08:51:54 -0700 [thread overview]
Message-ID: <YtbTGjRw65QEKkQA@infradead.org> (raw)
In-Reply-To: <YtbRwO40CmIRWOUR@google.com>
On Tue, Jul 19, 2022 at 03:46:08PM +0000, Keir Fraser wrote:
> However, if the general idea at least is acceptable, would the
> implementation be acceptable if I add an explicit API for this to the
> DMA subsystem, and hide the detail there?
I don't think so. The right thing to key off is
VIRTIO_F_ACCESS_PLATFORM, which really should be set in any modern
virtio device after all the problems we had with the lack of it.
> Or a completely different approach would be to revert the patch
> e41b1355508d which clears VIRTIO_F_ACCESS_PLATFORM in the balloon
> driver. MST: That's back in your court, as it's your patch!
Which also means this needs to be addresses, but I don't think a
simple revert is enough.
next prev parent reply other threads:[~2022-07-19 15:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 10:02 [PATCH] virtio: Force DMA restricted devices through DMA API Keir Fraser
2022-07-19 11:56 ` Michael S. Tsirkin
2022-07-19 14:05 ` Keir Fraser
2022-07-19 21:31 ` Michael S. Tsirkin
2022-07-19 15:23 ` Christoph Hellwig
2022-07-19 15:46 ` Keir Fraser
2022-07-19 15:51 ` Christoph Hellwig [this message]
2022-07-19 16:11 ` Keir Fraser
2022-07-20 5:16 ` Christoph Hellwig
2022-07-20 6:59 ` Michael S. Tsirkin
2022-07-20 8:27 ` Keir Fraser
2022-07-20 9:58 ` Michael S. Tsirkin
2022-07-21 7:37 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtbTGjRw65QEKkQA@infradead.org \
--to=hch@infradead.org \
--cc=jasowang@redhat.com \
--cc=keirf@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).