Re: Missing MIPI IPU6 camera driver for Intel Alder Lake laptops

From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Paul Menzel <pmenzel@molgen.mpg.de>,
	Wang Yating <yating.wang@intel.com>,
	Christoph Jechlitschek <christoph.jechlitschek@intel.com>,
	Hao Yao <hao.yao@intel.com>, Andy Yeh <andy.yeh@intel.com>,
	Bingbu Cao <bingbu.cao@intel.com>,
	Tianshu Qiu <tian.shu.qiu@intel.com>,
	linux-media@vger.kernel.org,
	Mark Pearson <markpearson@lenovo.com>,
	Dell.Client.Kernel@dell.com, linux-kernel@vger.kernel.org,
	Guenter Roeck <groeck@google.com>,
	Andy Whitcroft <apw@canonical.com>,
	Kai-Heng Feng <kai.heng.feng@canonical.com>,
	Christian Schaller <cschalle@redhat.com>,
	Wouter Bolsterlee <wouter@bolsterl.ee>,
	Miguel Palhas <mpalhas@gmail.com>,
	it+linux-media@molgen.mpg.de
Subject: Re: Missing MIPI IPU6 camera driver for Intel Alder Lake laptops
Date: Mon, 15 Aug 2022 09:47:55 +0000	[thread overview]
Message-ID: <YvoWSyWmmLvbW4Mr@paasikivi.fi.intel.com> (raw)
In-Reply-To: <YvnrJBI8599+E43T@google.com>

Hi Sergey,

On Mon, Aug 15, 2022 at 03:43:48PM +0900, Sergey Senozhatsky wrote:
> On (22/08/15 08:36), Greg KH wrote:
> > On Mon, Aug 15, 2022 at 11:06:39AM +0900, Sergey Senozhatsky wrote:
> > > On (22/08/11 17:30), Greg KH wrote:
> > > > On Thu, Aug 11, 2022 at 06:08:55PM +0300, Laurent Pinchart wrote:
> > > > > On Thu, Aug 11, 2022 at 05:02:40PM +0200, Greg KH wrote:
> > > > > > On Thu, Aug 11, 2022 at 04:54:53PM +0300, Laurent Pinchart wrote:
> > > > > > > For the time being, I agree with your recommendation to not buy these
> > > > > > > devices if you care about camera support.
> > > > > > 
> > > > > > I second this, don't buy these devices if the vendor is not willing to
> > > > > > get their drivers upstreamed properly.
> > > > > 
> > > > > "Not willing" may be a bit too harsh here. I wouldn't just blame Intel
> > > > > for not upstreaming a driver if it turns out that the V4L2 API isn't a
> > > > > good match and we have no proposal to provide an alternative.
> > > > 
> > > > Did they propose an alternative?  From what I saw here they didn't even
> > > > attempt it, or did I miss that?
> > > 
> > > The plan here is to land CAM kernel API first and then switch IPU
> > > (driver and user-space) to it so that upstreaming for Intel will
> > > be easier.
> > 
> > And what is the timeframe on the plan?  Where will these changes be sent
> > to for review?  I'm guessing they are already in a shipping device so
> > what's the delay?
> 
> We haven't sent out KCAM for upstream review yet. It's open sourced,
> as of this moment [1], but we still need some time and wanted to convert
> one of the previous generations of IPU drivers (IPU3) to KCAM first to
> see if everything is working as we wanted it to.
> 
> [1] For everyone who is curious, our first public KCAM version can
> be found here:
> https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/3668500/

Thanks for the URL.

Looking at the code, I wouldn't have guessed this is an API for cameras if
I hadn't been told so. I expect changes, possibly major changes, in the API
as well as the underlying framework will be needed for upstreaming. The
exact API toward user space that is required to make use of the camera
related hardware doesn't seem to be there, nor there seem to be any
in-kernel API for exchanging information between drivers.

Having said that, I don't want to judge this too harshly (e.g. without
documentation that supposedly will be written?) at this point as it is not
meant for upstream review yet. Drivers for actual hardware would tell more,
too.

-- 
Regards,

Sakari Ailus