From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8887C77B7C for ; Thu, 4 May 2023 08:26:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229918AbjEDIZ6 (ORCPT ); Thu, 4 May 2023 04:25:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229873AbjEDIZR (ORCPT ); Thu, 4 May 2023 04:25:17 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81C2F59F5 for ; Thu, 4 May 2023 01:17:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683188269; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Crz7SVqLScSwCZtKT1O0mIOH4ecEo3dE2+AhPDuZk1M=; b=A5OpTG9qfRRJBZbEvQE9vw//p98yQcMROL0UDDloQzVeE30peqIumY63Ui7CcLhaSE8bw4 ChevWVwALne7n9w/V4/lhmLtlp4hZDxZAZOYP0bA8qC1wW1SuSy9pQKIM4k0IaIP46Z92E 93t39G4asQLHmhiR51Zmg9wTMgyX+ZU= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-516-6zQFHLq9MbqEjM5MDCTo7Q-1; Thu, 04 May 2023 04:17:47 -0400 X-MC-Unique: 6zQFHLq9MbqEjM5MDCTo7Q-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3f1754de18cso1143825e9.1 for ; Thu, 04 May 2023 01:17:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683188266; x=1685780266; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Crz7SVqLScSwCZtKT1O0mIOH4ecEo3dE2+AhPDuZk1M=; b=P0lv53GCa2DwSP8nUechtPwbMDMvLsLU0k4+4Ch8yMcGgeJOQUtuMyGVSz/Uzi6gD9 QyaO2KIQRld0mZ/VJ0msd7A+uIcuwHL/B0eDyVfWJzwbctsCIZhu3uEm80KjPiIsJquM CnqYGW7pbhwG24e6SbEzoafr00jgwZlu0F+HIEST6VRBlSTW06eMPz3qdXS0LAIDI0wS 5VXH4pgtdc4Cw0+I9K4OEEjf6qNfvL76J4zj+W7g4d73h8op/2fs/JuGT1YuPpRr7CRk +67ZECp7Y0TFNqSsO4KxsIeeSnB8jEqBUxLUj+cEIm2fEw+lC1oHg1bHhCkThAepkDq2 4gRg== X-Gm-Message-State: AC+VfDwBLmBaROmXjC/c21MDJV4qF365eRbBABVp+mhZcHp40QJ7kJO3 zxQ3flw5iKiXXSzO/U1pAxn0AqevekLtBz6dH5qe78fDjjIIhfqthIdIp9zMmyGo6GxJaEq/6kU 3oQdGXa9kLF6S0Hs8cJyV8Ajl X-Received: by 2002:a1c:f706:0:b0:3f2:5028:a54d with SMTP id v6-20020a1cf706000000b003f25028a54dmr16070661wmh.0.1683188266678; Thu, 04 May 2023 01:17:46 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6ygZA0+8BWMej52snss9QosIIaPxtfMMgRoAO9qgdZm3GDEZS/f3ULO0hISpI8k0QQ8dyENg== X-Received: by 2002:a1c:f706:0:b0:3f2:5028:a54d with SMTP id v6-20020a1cf706000000b003f25028a54dmr16070625wmh.0.1683188266284; Thu, 04 May 2023 01:17:46 -0700 (PDT) Received: from localhost.localdomain ([2a02:b121:8011:79a:2d6b:5410:3927:2f38]) by smtp.gmail.com with ESMTPSA id l7-20020a5d4bc7000000b002fefe2edb72sm35979993wrt.17.2023.05.04.01.17.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 May 2023 01:17:45 -0700 (PDT) Date: Thu, 4 May 2023 10:17:41 +0200 From: Juri Lelli To: Peter Zijlstra Cc: Ingo Molnar , Qais Yousef , Waiman Long , Tejun Heo , Zefan Li , Johannes Weiner , Hao Luo , Dietmar Eggemann , Steven Rostedt , linux-kernel@vger.kernel.org, luca.abeni@santannapisa.it, claudio@evidence.eu.com, tommaso.cucinotta@santannapisa.it, bristot@redhat.com, mathieu.poirier@linaro.org, cgroups@vger.kernel.org, Vincent Guittot , Wei Wang , Rick Yiu , Quentin Perret , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sudeep Holla Subject: Re: [PATCH v2 0/6] sched/deadline: cpuset: Rework DEADLINE bandwidth restoration Message-ID: References: <20230503072228.115707-1-juri.lelli@redhat.com> <20230504062525.GF1734100@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230504062525.GF1734100@hirez.programming.kicks-ass.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/05/23 08:25, Peter Zijlstra wrote: > On Wed, May 03, 2023 at 09:22:22AM +0200, Juri Lelli wrote: > > > Dietmar Eggemann (2): > > sched/deadline: Create DL BW alloc, free & check overflow interface > > cgroup/cpuset: Free DL BW in case can_attach() fails > > > > Juri Lelli (4): > > cgroup/cpuset: Rename functions dealing with DEADLINE accounting > > sched/cpuset: Bring back cpuset_mutex > > sched/cpuset: Keep track of SCHED_DEADLINE task in cpusets > > cgroup/cpuset: Iterate only if DEADLINE tasks are present > > > > include/linux/cpuset.h | 12 +- > > include/linux/sched.h | 4 +- > > kernel/cgroup/cgroup.c | 4 + > > kernel/cgroup/cpuset.c | 242 ++++++++++++++++++++++++++-------------- > > kernel/sched/core.c | 41 +++---- > > kernel/sched/deadline.c | 67 ++++++++--- > > kernel/sched/sched.h | 2 +- > > 7 files changed, 244 insertions(+), 128 deletions(-) > > Aside from a few niggles, these look fine to me. Who were you expecting > to merge these, tj or me? Thanks for reviewing! Not entirely sure, it's kind of split, but maybe the cgroup changes are predominant (cpuset_mutex is probably contributing the most). So, maybe tj? Assuming this looks good to him as well of course. :) Thanks!