From: Juri Lelli <juri.lelli@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>, Qais Yousef <qyousef@layalina.io>,
Waiman Long <longman@redhat.com>,
Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>, Hao Luo <haoluo@google.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, luca.abeni@santannapisa.it,
claudio@evidence.eu.com, tommaso.cucinotta@santannapisa.it,
bristot@redhat.com, mathieu.poirier@linaro.org,
cgroups@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
Wei Wang <wvw@google.com>, Rick Yiu <rickyiu@google.com>,
Quentin Perret <qperret@google.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH v2 0/6] sched/deadline: cpuset: Rework DEADLINE bandwidth restoration
Date: Mon, 8 May 2023 10:02:46 +0200 [thread overview]
Message-ID: <ZFispnba4DZt50Io@localhost.localdomain> (raw)
In-Reply-To: <ZFVZdbdZTLGhqYp4@slm.duckdns.org>
Hi,
On 05/05/23 09:31, Tejun Heo wrote:
> On Thu, May 04, 2023 at 10:17:41AM +0200, Juri Lelli wrote:
> > On 04/05/23 08:25, Peter Zijlstra wrote:
> > > On Wed, May 03, 2023 at 09:22:22AM +0200, Juri Lelli wrote:
> > >
> > > > Dietmar Eggemann (2):
> > > > sched/deadline: Create DL BW alloc, free & check overflow interface
> > > > cgroup/cpuset: Free DL BW in case can_attach() fails
> > > >
> > > > Juri Lelli (4):
> > > > cgroup/cpuset: Rename functions dealing with DEADLINE accounting
> > > > sched/cpuset: Bring back cpuset_mutex
> > > > sched/cpuset: Keep track of SCHED_DEADLINE task in cpusets
> > > > cgroup/cpuset: Iterate only if DEADLINE tasks are present
> > > >
> > > > include/linux/cpuset.h | 12 +-
> > > > include/linux/sched.h | 4 +-
> > > > kernel/cgroup/cgroup.c | 4 +
> > > > kernel/cgroup/cpuset.c | 242 ++++++++++++++++++++++++++--------------
> > > > kernel/sched/core.c | 41 +++----
> > > > kernel/sched/deadline.c | 67 ++++++++---
> > > > kernel/sched/sched.h | 2 +-
> > > > 7 files changed, 244 insertions(+), 128 deletions(-)
> > >
> > > Aside from a few niggles, these look fine to me. Who were you expecting
> > > to merge these, tj or me?
> >
> > Thanks for reviewing!
> >
> > Not entirely sure, it's kind of split, but maybe the cgroup changes are
> > predominant (cpuset_mutex is probably contributing the most). So, maybe
> > tj? Assuming this looks good to him as well of course. :)
>
> Yeah, they all look sane to me and both Waiman and Peter seem okay with
> them. If you post an updated version with the minor suggestions applied,
> I'll route the series through the cgroup tree.
Thanks for reviewing and eventually taking care of the series. v3 just
posted (20230508075854.17215-1-juri.lelli@redhat.com).
Best,
Juri
prev parent reply other threads:[~2023-05-08 8:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 7:22 [PATCH v2 0/6] sched/deadline: cpuset: Rework DEADLINE bandwidth restoration Juri Lelli
2023-05-03 7:22 ` [PATCH v2 1/6] cgroup/cpuset: Rename functions dealing with DEADLINE accounting Juri Lelli
2023-05-03 17:54 ` Waiman Long
2023-05-03 7:22 ` [PATCH v2 2/6] sched/cpuset: Bring back cpuset_mutex Juri Lelli
2023-05-03 17:55 ` Waiman Long
2023-05-04 6:18 ` Peter Zijlstra
2023-05-04 8:13 ` Juri Lelli
2023-05-04 6:21 ` Peter Zijlstra
2023-05-04 8:13 ` Juri Lelli
2023-05-03 7:22 ` [PATCH v2 3/6] sched/cpuset: Keep track of SCHED_DEADLINE task in cpusets Juri Lelli
2023-05-03 17:56 ` Waiman Long
2023-05-03 7:22 ` [PATCH v2 4/6] cgroup/cpuset: Iterate only if DEADLINE tasks are present Juri Lelli
2023-05-03 17:56 ` Waiman Long
2023-05-03 7:22 ` [PATCH v2 5/6] sched/deadline: Create DL BW alloc, free & check overflow interface Juri Lelli
2023-05-03 17:45 ` Waiman Long
2023-05-04 6:23 ` Peter Zijlstra
2023-05-04 8:15 ` Juri Lelli
2023-05-04 17:21 ` Dietmar Eggemann
2023-05-03 7:22 ` [PATCH v2 6/6] cgroup/cpuset: Free DL BW in case can_attach() fails Juri Lelli
2023-05-03 18:02 ` Waiman Long
2023-05-04 6:25 ` [PATCH v2 0/6] sched/deadline: cpuset: Rework DEADLINE bandwidth restoration Peter Zijlstra
2023-05-04 8:17 ` Juri Lelli
2023-05-05 19:31 ` Tejun Heo
2023-05-08 8:02 ` Juri Lelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFispnba4DZt50Io@localhost.localdomain \
--to=juri.lelli@redhat.com \
--cc=agordeev@linux.ibm.com \
--cc=bristot@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=claudio@evidence.eu.com \
--cc=dietmar.eggemann@arm.com \
--cc=gor@linux.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=haoluo@google.com \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
--cc=luca.abeni@santannapisa.it \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=qyousef@layalina.io \
--cc=rickyiu@google.com \
--cc=rostedt@goodmis.org \
--cc=sudeep.holla@arm.com \
--cc=tj@kernel.org \
--cc=tommaso.cucinotta@santannapisa.it \
--cc=vincent.guittot@linaro.org \
--cc=wvw@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).