From: Yujie Liu <yujie.liu@intel.com>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: kernel test robot <lkp@intel.com>,
Frederic Weisbecker <frederic@kernel.org>,
<oe-kbuild-all@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
Boqun Feng <boqun.feng@gmail.com>,
"Joel Fernandes (Google)" <joel@joelfernandes.org>
Subject: Re: ERROR: modpost: vmlinux: local symbol 'rcu_set_jiffies_lazy_flush' was exported
Date: Sat, 11 May 2024 10:53:23 +0800 [thread overview]
Message-ID: <Zj7do9o265Rrm1HD@yujie-X299> (raw)
In-Reply-To: <965221ae-620a-497a-9a80-5725e3fe3f7b@paulmck-laptop>
On Fri, May 10, 2024 at 12:09:02PM -0700, Paul E. McKenney wrote:
> On Sat, May 11, 2024 at 02:53:06AM +0800, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head: f4345f05c0dfc73c617e66f3b809edb8ddd41075
> > commit: 499d7e7e83d25fcf0fa1a8c0be6857a84cbf6a4a rcu: Rename jiffies_till_flush to jiffies_lazy_flush
> > date: 3 months ago
> > config: riscv-randconfig-r021-20230817 (https://download.01.org/0day-ci/archive/20240511/202405110230.vcpgN5vz-lkp@intel.com/config)
> > compiler: riscv32-linux-gcc (GCC) 13.2.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240511/202405110230.vcpgN5vz-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202405110230.vcpgN5vz-lkp@intel.com/
> >
> > All errors (new ones prefixed by >>, old ones prefixed by <<):
> >
> > >> ERROR: modpost: vmlinux: local symbol 'rcu_set_jiffies_lazy_flush' was exported
> > >> ERROR: modpost: vmlinux: local symbol 'rcu_get_jiffies_lazy_flush' was exported
>
> These do not look to me to be local:
>
> void rcu_set_jiffies_lazy_flush(unsigned long jif)
> {
> jiffies_lazy_flush = jif;
> }
> EXPORT_SYMBOL(rcu_set_jiffies_lazy_flush);
>
> unsigned long rcu_get_jiffies_lazy_flush(void)
> {
> return jiffies_lazy_flush;
> }
> EXPORT_SYMBOL(rcu_get_jiffies_lazy_flush);
>
> What am I missing here?
Sorry this is a false positive. We will fix the bot to handle
this case correctly.
Thanks,
Yujie
next prev parent reply other threads:[~2024-05-11 2:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 18:53 ERROR: modpost: vmlinux: local symbol 'rcu_set_jiffies_lazy_flush' was exported kernel test robot
2024-05-10 19:09 ` Paul E. McKenney
2024-05-11 2:53 ` Yujie Liu [this message]
2024-05-11 4:42 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zj7do9o265Rrm1HD@yujie-X299 \
--to=yujie.liu@intel.com \
--cc=boqun.feng@gmail.com \
--cc=frederic@kernel.org \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=paulmck@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).