From: Sibi Sankar <sibis@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, stable@vger.kernel.org,
linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH] remoteproc: qcom: q6v5: Propagate EPROBE_DEFER
Date: Tue, 25 Sep 2018 12:20:00 +0530 [thread overview]
Message-ID: <a1fdf85cb2e23b173243ba3b43b818bb@codeaurora.org> (raw)
In-Reply-To: <20180920015151.15957-1-bjorn.andersson@linaro.org>
On 2018-09-20 07:21, Bjorn Andersson wrote:
> In the case that the interrupts fail to result because of the
> interrupt-controller not yet being registered the
> platform_get_irq_byname() call will fail with -EPROBE_DEFER, but
> passing
> this into devm_request_threaded_irq() will result in -EINVAL being
> returned, the driver is therefor not reprobed later.
>
The patch looks fine.
Reviewed-by: Sibi Sankar <sibis@codeaurora.org>
> Fixes: 3b415c8fb263 ("remoteproc: q6v5: Extract common resource
> handling")
> Cc: stable@vger.kernel.org
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/remoteproc/qcom_q6v5.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/remoteproc/qcom_q6v5.c
> b/drivers/remoteproc/qcom_q6v5.c
> index 61a760ee4aac..e9ab90c19304 100644
> --- a/drivers/remoteproc/qcom_q6v5.c
> +++ b/drivers/remoteproc/qcom_q6v5.c
> @@ -198,6 +198,9 @@ int qcom_q6v5_init(struct qcom_q6v5 *q6v5, struct
> platform_device *pdev,
> }
>
> q6v5->fatal_irq = platform_get_irq_byname(pdev, "fatal");
> + if (q6v5->fatal_irq == -EPROBE_DEFER)
> + return -EPROBE_DEFER;
> +
> ret = devm_request_threaded_irq(&pdev->dev, q6v5->fatal_irq,
> NULL, q6v5_fatal_interrupt,
> IRQF_TRIGGER_RISING | IRQF_ONESHOT,
> @@ -208,6 +211,9 @@ int qcom_q6v5_init(struct qcom_q6v5 *q6v5, struct
> platform_device *pdev,
> }
>
> q6v5->ready_irq = platform_get_irq_byname(pdev, "ready");
> + if (q6v5->ready_irq == -EPROBE_DEFER)
> + return -EPROBE_DEFER;
> +
> ret = devm_request_threaded_irq(&pdev->dev, q6v5->ready_irq,
> NULL, q6v5_ready_interrupt,
> IRQF_TRIGGER_RISING | IRQF_ONESHOT,
> @@ -218,6 +224,9 @@ int qcom_q6v5_init(struct qcom_q6v5 *q6v5, struct
> platform_device *pdev,
> }
>
> q6v5->handover_irq = platform_get_irq_byname(pdev, "handover");
> + if (q6v5->handover_irq == -EPROBE_DEFER)
> + return -EPROBE_DEFER;
> +
> ret = devm_request_threaded_irq(&pdev->dev, q6v5->handover_irq,
> NULL, q6v5_handover_interrupt,
> IRQF_TRIGGER_RISING | IRQF_ONESHOT,
> @@ -229,6 +238,9 @@ int qcom_q6v5_init(struct qcom_q6v5 *q6v5, struct
> platform_device *pdev,
> disable_irq(q6v5->handover_irq);
>
> q6v5->stop_irq = platform_get_irq_byname(pdev, "stop-ack");
> + if (q6v5->stop_irq == -EPROBE_DEFER)
> + return -EPROBE_DEFER;
> +
> ret = devm_request_threaded_irq(&pdev->dev, q6v5->stop_irq,
> NULL, q6v5_stop_interrupt,
> IRQF_TRIGGER_RISING | IRQF_ONESHOT,
--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2018-09-25 6:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 1:51 [PATCH] remoteproc: qcom: q6v5: Propagate EPROBE_DEFER Bjorn Andersson
2018-09-25 6:50 ` Sibi Sankar [this message]
2018-10-06 6:39 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1fdf85cb2e23b173243ba3b43b818bb@codeaurora.org \
--to=sibis@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).