linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: ye.xingchen@zte.com.cn, mcgrof@kernel.org
Cc: keescook@chromium.org, yzaikin@google.com,
	akpm@linux-foundation.org, chi.minghao@zte.com.cn,
	linmiaohe@huawei.com, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH V8 1/2] mm: compaction: move compaction sysctl to its own file
Date: Tue, 28 Mar 2023 10:56:52 +0200	[thread overview]
Message-ID: <a231f05c-b157-f495-bf06-8aca903c7e17@suse.cz> (raw)
In-Reply-To: <202303281446280457758@zte.com.cn>

On 3/28/23 08:46, ye.xingchen@zte.com.cn wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
> 
> This moves all compaction sysctls to its own file.
> 
> Move sysctl to where the functionality truly belongs to improve
> readability, reduce merge conflicts, and facilitate maintenance.
> 
> I use x86_defconfig and linux-next-20230327 branch
> $ make defconfig;make all -jn
> CONFIG_COMPACTION=y
> 
> add/remove: 1/0 grow/shrink: 1/1 up/down: 350/-256 (94)
> Function                                     old     new   delta
> vm_compaction                                  -     320    +320
> kcompactd_init                               180     210     +30
> vm_table                                    2112    1856    -256
> Total: Before=21119987, After=21120081, chg +0.00%
> 
> Despite the addition of 94 bytes the patch still seems a worthwile
> cleanup.
> 
> Link: https://lore.kernel.org/lkml/067f7347-ba10-5405-920c-0f5f985c84f4@suse.cz/
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>

Acked-by: Vlastimil Babka <vbabka@suse.cz>

Thanks.

  reply	other threads:[~2023-03-28  8:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-28  6:46 [PATCH V8 1/2] mm: compaction: move compaction sysctl to its own file ye.xingchen
2023-03-28  8:56 ` Vlastimil Babka [this message]
2023-03-28 17:46   ` Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a231f05c-b157-f495-bf06-8aca903c7e17@suse.cz \
    --to=vbabka@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=chi.minghao@zte.com.cn \
    --cc=keescook@chromium.org \
    --cc=linmiaohe@huawei.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mcgrof@kernel.org \
    --cc=ye.xingchen@zte.com.cn \
    --cc=yzaikin@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).