From: Tom Lendacky <thomas.lendacky@amd.com>
To: Borislav Petkov <bp@alien8.de>, X86 ML <x86@kernel.org>
Cc: Arjan Van De Ven <arjan.van.de.ven@intel.com>,
Ashok Raj <ashok.raj@intel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/7] x86/microcode: Request microcode on the BSP
Date: Mon, 5 Mar 2018 16:08:08 -0600 [thread overview]
Message-ID: <a5518704-2264-07b4-dd13-84f0086dbe08@amd.com> (raw)
In-Reply-To: <20180228102846.13447-7-bp@alien8.de>
On 2/28/2018 4:28 AM, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
>
> ... so that any newer version can land in the cache and can later be
> fished out by the application functions. Do that before grabbing the
> hotplug lock.
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> ---
> arch/x86/kernel/cpu/microcode/core.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
> diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/microcode/core.c
> index fa32cb3dcca5..5dd157d48606 100644
> --- a/arch/x86/kernel/cpu/microcode/core.c
> +++ b/arch/x86/kernel/cpu/microcode/core.c
> @@ -499,15 +499,10 @@ static int check_online_cpus(void)
> static enum ucode_state reload_for_cpu(int cpu)
> {
> struct ucode_cpu_info *uci = ucode_cpu_info + cpu;
> - enum ucode_state ustate;
>
> if (!uci->valid)
> return UCODE_OK;
>
> - ustate = microcode_ops->request_microcode_fw(cpu, µcode_pdev->dev, true);
> - if (ustate != UCODE_OK)
> - return ustate;
> -
> return apply_microcode_on_target(cpu);
> }
>
> @@ -515,11 +510,11 @@ static ssize_t reload_store(struct device *dev,
> struct device_attribute *attr,
> const char *buf, size_t size)
> {
> + int cpu, bsp = boot_cpu_data.cpu_index;
> enum ucode_state tmp_ret = UCODE_OK;
> bool do_callback = false;
> unsigned long val;
> ssize_t ret = 0;
> - int cpu;
>
> ret = kstrtoul(buf, 0, &val);
> if (ret)
> @@ -528,6 +523,10 @@ static ssize_t reload_store(struct device *dev,
> if (val != 1)
> return size;
>
> + tmp_ret = microcode_ops->request_microcode_fw(bsp, µcode_pdev->dev, true);
> + if (tmp_ret != UCODE_OK)
> + return size;
> +
> get_online_cpus();
>
> ret = check_online_cpus();
>
next prev parent reply other threads:[~2018-03-05 22:08 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 10:28 [PATCH 0/7] x86/microcode: Improve late loading Borislav Petkov
2018-02-28 10:28 ` [PATCH 1/7] x86/microcode: Get rid of struct apply_microcode_ctx Borislav Petkov
2018-03-08 9:25 ` [tip:x86/pti] " tip-bot for Borislav Petkov
2018-02-28 10:28 ` [PATCH 2/7] x86/microcode/intel: Check microcode revision before updating sibling threads Borislav Petkov
2018-03-08 9:25 ` [tip:x86/pti] " tip-bot for Ashok Raj
2018-02-28 10:28 ` [PATCH 3/7] x86/microcode/intel: Writeback and invalidate caches before updating microcode Borislav Petkov
2018-03-08 9:26 ` [tip:x86/pti] " tip-bot for Ashok Raj
2018-02-28 10:28 ` [PATCH 4/7] x86/microcode: Do not upload microcode if CPUs are offline Borislav Petkov
2018-02-28 13:11 ` Henrique de Moraes Holschuh
2018-02-28 13:26 ` Raj, Ashok
2018-02-28 19:07 ` Henrique de Moraes Holschuh
2018-03-05 22:06 ` Tom Lendacky
2018-03-08 9:26 ` [tip:x86/pti] " tip-bot for Ashok Raj
2018-02-28 10:28 ` [PATCH 5/7] x86/microcode/intel: Look into the patch cache first Borislav Petkov
2018-03-08 9:27 ` [tip:x86/pti] " tip-bot for Borislav Petkov
2018-02-28 10:28 ` [PATCH 6/7] x86/microcode: Request microcode on the BSP Borislav Petkov
2018-03-05 22:08 ` Tom Lendacky [this message]
2018-03-08 9:27 ` [tip:x86/pti] " tip-bot for Borislav Petkov
2018-02-28 10:28 ` [PATCH 7/7] x86/microcode: Synchronize late microcode loading Borislav Petkov
2018-02-28 13:59 ` Henrique de Moraes Holschuh
2018-02-28 14:08 ` Borislav Petkov
2018-02-28 17:48 ` Henrique de Moraes Holschuh
2018-03-05 22:09 ` Tom Lendacky
2018-03-08 9:28 ` [tip:x86/pti] " tip-bot for Ashok Raj
2018-03-05 22:12 ` [PATCH 0/7] x86/microcode: Improve late loading Tom Lendacky
2018-03-05 23:51 ` Raj, Ashok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5518704-2264-07b4-dd13-84f0086dbe08@amd.com \
--to=thomas.lendacky@amd.com \
--cc=arjan.van.de.ven@intel.com \
--cc=ashok.raj@intel.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).