From: Mukesh Ojha <quic_mojha@quicinc.com>
To: Li kunyu <kunyu@nfschina.com>, <mingo@redhat.com>,
<peterz@infradead.org>, <juri.lelli@redhat.com>,
<vincent.guittot@linaro.org>, <dietmar.eggemann@arm.com>,
<rostedt@goodmis.org>, <bsegall@google.com>, <mgorman@suse.de>,
<bristot@redhat.com>, <vschneid@redhat.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched: deadline: Simplify pick_earliest_pushable_dl_task()
Date: Mon, 29 May 2023 11:59:59 +0530 [thread overview]
Message-ID: <a6db7f89-bc62-9627-0bd1-1c66b72fc7dd@quicinc.com> (raw)
In-Reply-To: <20230530181145.2880-1-kunyu@nfschina.com>
On 5/30/2023 11:41 PM, Li kunyu wrote:
> Using the while statement instead of the if and goto statements is more
> concise and efficient.
>
> Signed-off-by: Li kunyu <kunyu@nfschina.com>
LGTM, Thanks.
Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>
-- Mukesh
> ---
> kernel/sched/deadline.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index d823e608c7f0..b94a498f8cd9 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -2112,15 +2112,13 @@ static struct task_struct *pick_earliest_pushable_dl_task(struct rq *rq, int cpu
>
> next_node = rb_first_cached(&rq->dl.pushable_dl_tasks_root);
>
> -next_node:
> - if (next_node) {
> + while (next_node) {
> p = __node_2_pdl(next_node);
>
> if (pick_dl_task(rq, p, cpu))
> return p;
>
> next_node = rb_next(next_node);
> - goto next_node;
> }
>
> return NULL;
prev parent reply other threads:[~2023-05-29 6:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 18:11 [PATCH] sched: deadline: Simplify pick_earliest_pushable_dl_task() Li kunyu
2023-05-29 6:29 ` Mukesh Ojha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6db7f89-bc62-9627-0bd1-1c66b72fc7dd@quicinc.com \
--to=quic_mojha@quicinc.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kunyu@nfschina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).