From: Todor Tomov <todor.tomov@linaro.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
mchehab@kernel.org, robh+dt@kernel.org, hansverk@cisco.com
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: media: i2c: Fix i2c address for OV5645 camera sensor
Date: Fri, 9 Nov 2018 10:57:14 +0200 [thread overview]
Message-ID: <a777f934-9adb-83d7-b0b6-0777563410c0@linaro.org> (raw)
In-Reply-To: <20181109075643.17575-1-manivannan.sadhasivam@linaro.org>
Hi Mani,
On 9.11.2018 09:56, Manivannan Sadhasivam wrote:
> The i2c address for the Omnivision OV5645 camera sensor is 0x3c. It is
> incorrectly mentioned as 0x78 in binding. Hence fix that.
The seven bit i2c address of ov5645 is really 0x3c.
Thank you for finding this and sending the fix!
Best regards,
Todor
>
> Fixes: 09c716af36e6 [media] media: i2c/ov5645: add the device tree binding document
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> Documentation/devicetree/bindings/media/i2c/ov5645.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/ov5645.txt b/Documentation/devicetree/bindings/media/i2c/ov5645.txt
> index fd7aec9f8e24..1a68ca5eb9a3 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ov5645.txt
> +++ b/Documentation/devicetree/bindings/media/i2c/ov5645.txt
> @@ -26,9 +26,9 @@ Example:
> &i2c1 {
> ...
>
> - ov5645: ov5645@78 {
> + ov5645: ov5645@3c {
> compatible = "ovti,ov5645";
> - reg = <0x78>;
> + reg = <0x3c>;
>
> enable-gpios = <&gpio1 6 GPIO_ACTIVE_HIGH>;
> reset-gpios = <&gpio5 20 GPIO_ACTIVE_LOW>;
>
next prev parent reply other threads:[~2018-11-09 8:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 7:56 [PATCH] dt-bindings: media: i2c: Fix i2c address for OV5645 camera sensor Manivannan Sadhasivam
2018-11-09 8:57 ` Todor Tomov [this message]
2018-11-17 16:41 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a777f934-9adb-83d7-b0b6-0777563410c0@linaro.org \
--to=todor.tomov@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=hansverk@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).