From: Daniel Bristot de Oliveira <bristot@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Juri Lelli <juri.lelli@redhat.com>,
Clark Williams <williams@redhat.com>,
Bagas Sanjaya <bagasdotme@gmail.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 2/3] tracing/osnoise: Add preempt and/or irq disabled options
Date: Fri, 9 Dec 2022 22:16:55 +0100 [thread overview]
Message-ID: <a91587c2-7faa-f23b-c472-f65dc5cdaae7@kernel.org> (raw)
In-Reply-To: <20221209153552.4c7099cd@gandalf.local.home>
On 12/9/22 21:35, Steven Rostedt wrote:
>> + if (preempt_disable)
>> + preempt_disable();
>> +
> The only reason the above works is because preempt_disable() is a macro.
> If it was a function, then it would likely fail to build (as you are
> overriding the name with a bool variable).
oops.
Sending a new version changing the variable name.
-- Daniel
next prev parent reply other threads:[~2022-12-09 21:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 18:19 [PATCH V4 0/3] Add osnoise/options options Daniel Bristot de Oliveira
2022-11-30 18:19 ` [PATCH V4 1/3] tracing/osnoise: Add PANIC_ON_STOP option Daniel Bristot de Oliveira
2022-11-30 18:19 ` [PATCH V4 2/3] tracing/osnoise: Add preempt and/or irq disabled options Daniel Bristot de Oliveira
2022-12-09 20:35 ` Steven Rostedt
2022-12-09 21:16 ` Daniel Bristot de Oliveira [this message]
2022-11-30 18:35 ` [PATCH V4 3/3] Documentation/osnoise: Add osnoise/options documentation Daniel Bristot de Oliveira
2022-12-01 3:59 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a91587c2-7faa-f23b-c472-f65dc5cdaae7@kernel.org \
--to=bristot@kernel.org \
--cc=bagasdotme@gmail.com \
--cc=corbet@lwn.net \
--cc=juri.lelli@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).