From: Jens Axboe <axboe@kernel.dk>
To: Zenghui Yu <yuzenghui@huawei.com>,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: fujita.tomonori@lab.ntt.co.jp, martin.petersen@oracle.com,
hch@lst.de, gregkh@linuxfoundation.org,
wanghaibin.wang@huawei.com
Subject: Re: [PATCH] scsi: bsg: Fix device unregistration
Date: Thu, 9 Sep 2021 14:42:10 -0600 [thread overview]
Message-ID: <ac61cf8b-061e-dd96-1730-edec5a886c62@kernel.dk> (raw)
In-Reply-To: <78c3c08b-ebba-8d46-7eae-f82d0b1c50fe@kernel.dk>
On 9/9/21 2:40 PM, Jens Axboe wrote:
> On 9/8/21 9:46 PM, Zenghui Yu wrote:
>> We use device_initialize() to take refcount for the device but forget to
>> put_device() on device teardown, which ends up leaking private data of the
>> driver core, dev_name(), etc. This is reported by kmemleak at boot time if
>> we compile kernel with DEBUG_TEST_DRIVER_REMOVE.
>>
>> Note that adding the missing put_device() is _not_ sufficient to fix device
>> unregistration. As we don't provide the .release() method for device, which
>> turned out to be typically wrong and will be complained loudly by the
>> driver core.
>>
>> Fix both of them.
>
> Applied, thanks.
Actually, let's move this through the SCSI tree, as the offending patch
went that way (and my branches are behind that point).
--
Jens Axboe
next prev parent reply other threads:[~2021-09-09 20:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 3:46 [PATCH] scsi: bsg: Fix device unregistration Zenghui Yu
2021-09-09 5:22 ` Christoph Hellwig
2021-09-09 5:36 ` Greg KH
2021-09-09 20:40 ` Jens Axboe
2021-09-09 20:42 ` Jens Axboe [this message]
2021-09-10 1:28 ` Martin K. Petersen
2021-09-10 7:38 ` Christoph Hellwig
2021-09-10 12:45 ` Johan Hovold
2021-09-10 16:50 ` Martin K. Petersen
2021-09-11 1:41 ` Zenghui Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac61cf8b-061e-dd96-1730-edec5a886c62@kernel.dk \
--to=axboe@kernel.dk \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=wanghaibin.wang@huawei.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).