From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Mark Brown <broonie@kernel.org>
Cc: Sven Van Asbroeck <thesven73@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-spi <linux-spi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>
Subject: Re: SPI not working on 5.10 and 5.11, bisected to 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")
Date: Thu, 14 Jan 2021 14:42:26 +0100 [thread overview]
Message-ID: <adbf508d-ed5a-e06a-4a59-98df0229d7b4@csgroup.eu> (raw)
In-Reply-To: <20210114132258.GD4854@sirena.org.uk>
Le 14/01/2021 à 14:22, Mark Brown a écrit :
>
> For GPIO chipselects you should really fix the driver to just hand the
> GPIO off to the core rather than trying to implement this itself, that
> will avoid driver specific differences like this.
>
IIUC, it is not trivial as it requires implementing transfer_one() instead of the existing
transfer_one_message() in the driver. Am I right ?
What's the difference/benefit of transfer_one() compared to the existing transfer_one_message() ?
next prev parent reply other threads:[~2021-01-14 13:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 8:49 SPI not working on 5.10 and 5.11, bisected to 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors") Christophe Leroy
2021-01-13 12:33 ` Mark Brown
2021-01-14 11:27 ` Christophe Leroy
2021-01-14 11:59 ` Mark Brown
2021-01-14 12:33 ` Christophe Leroy
2021-01-14 13:22 ` Mark Brown
2021-01-14 13:42 ` Christophe Leroy [this message]
2021-01-14 13:59 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adbf508d-ed5a-e06a-4a59-98df0229d7b4@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=broonie@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=thesven73@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).