From: "Sven Peter" <sven@svenpeter.dev>
To: "Geert Uytterhoeven" <geert+renesas@glider.be>,
"Joerg Roedel" <joro@8bytes.org>, "Will Deacon" <will@kernel.org>,
"Hector Martin" <marcan@marcan.st>
Cc: iommu@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu: APPLE_DART should depend on ARCH_APPLE
Date: Wed, 11 Aug 2021 12:58:10 +0200 [thread overview]
Message-ID: <ae4e4b9f-add0-4ab2-9c82-04124b1862b7@www.fastmail.com> (raw)
In-Reply-To: <44fcf525273b32c9afcd7e99acbd346d47f0e047.1628603162.git.geert+renesas@glider.be>
Good catch, thanks!
Acked-by: Sven Peter <sven@svenpeter.dev>
Sven
On Tue, Aug 10, 2021, at 15:47, Geert Uytterhoeven wrote:
> The Apple DART (Device Address Resolution Table) IOMMU is only present
> on Apple ARM SoCs like the M1. Hence add a dependency on ARCH_APPLE, to
> prevent asking the user about this driver when configuring a kernel
> without support for the Apple Silicon SoC family.
>
> Fixes: 05ce9d20d699b093 ("iommu/dart: Add DART iommu driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/iommu/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
> index dfe81da483e9e073..e908b8222e4ed679 100644
> --- a/drivers/iommu/Kconfig
> +++ b/drivers/iommu/Kconfig
> @@ -292,7 +292,7 @@ config SPAPR_TCE_IOMMU
>
> config APPLE_DART
> tristate "Apple DART IOMMU Support"
> - depends on ARM64 || (COMPILE_TEST && !GENERIC_ATOMIC64)
> + depends on ARCH_APPLE || (COMPILE_TEST && !GENERIC_ATOMIC64)
> select IOMMU_API
> select IOMMU_IO_PGTABLE_LPAE
> default ARCH_APPLE
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2021-08-11 10:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 13:47 [PATCH] iommu: APPLE_DART should depend on ARCH_APPLE Geert Uytterhoeven
2021-08-11 10:58 ` Sven Peter [this message]
2021-08-12 11:27 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae4e4b9f-add0-4ab2-9c82-04124b1862b7@www.fastmail.com \
--to=sven@svenpeter.dev \
--cc=geert+renesas@glider.be \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).