From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Michael Walle <michael@walle.cc>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Robert Marko <robimarko@gmail.com>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
Peng Fan <peng.fan@nxp.com>,
Miquel Raynal <miquel.raynal@bootlin.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Aisheng Dong <aisheng.dong@nxp.com>
Subject: Re: [PATCH] of: property: fix #nvmem-cell-cells parsing
Date: Fri, 20 Jan 2023 17:48:38 +0000 [thread overview]
Message-ID: <ae73ae73-3c5f-d8dc-fda8-0916c976a835@linaro.org> (raw)
In-Reply-To: <20230110233056.3490942-1-michael@walle.cc>
On 10/01/2023 23:30, Michael Walle wrote:
> Commit 67b8497f005f ("of: property: make #.*-cells optional for simple
> props") claims to make the cells-name property optional for simple
> properties, but changed the code for the wrong property, i.e. for
> DEFINE_SUFFIX_PROP(). Fix that.
>
> Fixes: 67b8497f005f ("of: property: make #.*-cells optional for simple props")
> Reported-by: Peng Fan <peng.fan@nxp.com>
> Signed-off-by: Michael Walle <michael@walle.cc>
> Tested-by: Robert Marko <robimarko@gmail.com>
> ---
Applied thanks,
--srini
> drivers/of/property.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/of/property.c b/drivers/of/property.c
> index 8d9ba20a8f90..95b838185b2f 100644
> --- a/drivers/of/property.c
> +++ b/drivers/of/property.c
> @@ -1202,8 +1202,8 @@ static struct device_node *parse_prop_cells(struct device_node *np,
> if (strcmp(prop_name, list_name))
> return NULL;
>
> - if (of_parse_phandle_with_args(np, list_name, cells_name, index,
> - &sup_args))
> + if (__of_parse_phandle_with_args(np, list_name, cells_name, 0, index,
> + &sup_args))
> return NULL;
>
> return sup_args.np;
> @@ -1256,8 +1256,8 @@ static struct device_node *parse_suffix_prop_cells(struct device_node *np,
> if (strcmp_suffix(prop_name, suffix))
> return NULL;
>
> - if (__of_parse_phandle_with_args(np, prop_name, cells_name, 0, index,
> - &sup_args))
> + if (of_parse_phandle_with_args(np, prop_name, cells_name, index,
> + &sup_args))
> return NULL;
>
> return sup_args.np;
prev parent reply other threads:[~2023-01-20 17:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 23:30 [PATCH] of: property: fix #nvmem-cell-cells parsing Michael Walle
2023-01-11 2:45 ` Peng Fan
2023-01-13 1:32 ` Rob Herring
2023-01-13 1:33 ` Rob Herring
2023-01-13 10:20 ` Michael Walle
2023-01-20 17:48 ` Srinivas Kandagatla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae73ae73-3c5f-d8dc-fda8-0916c976a835@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=aisheng.dong@nxp.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=robimarko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).