From: Stefano Stabellini <sstabellini@kernel.org>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
xen-devel@lists.xen.org, linux-kernel@vger.kernel.org,
jgross@suse.com, Stefano Stabellini <stefano@aporeto.com>
Subject: Re: [PATCH v3 12/13] xen/pvcalls: implement release command
Date: Fri, 8 Sep 2017 16:09:02 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1709081605500.19719@sstabellini-ThinkPad-X260> (raw)
In-Reply-To: <2fd1b3f3-28aa-1958-7522-766c7d92e8d3@oracle.com>
On Tue, 15 Aug 2017, Boris Ostrovsky wrote:
> On 07/31/2017 06:57 PM, Stefano Stabellini wrote:
> > Send PVCALLS_RELEASE to the backend and wait for a reply. Take both
> > in_mutex and out_mutex to avoid concurrent accesses. Then, free the
> > socket.
> >
> > For passive sockets, check whether we have already pre-allocated an
> > active socket for the purpose of being accepted. If so, free that as
> > well.
> >
> > Signed-off-by: Stefano Stabellini <stefano@aporeto.com>
> > CC: boris.ostrovsky@oracle.com
> > CC: jgross@suse.com
> > ---
> > drivers/xen/pvcalls-front.c | 88 +++++++++++++++++++++++++++++++++++++++++++++
> > drivers/xen/pvcalls-front.h | 1 +
> > 2 files changed, 89 insertions(+)
> >
> > diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c
> > index 1c975d6..775a6d2 100644
> > --- a/drivers/xen/pvcalls-front.c
> > +++ b/drivers/xen/pvcalls-front.c
> > @@ -192,6 +192,23 @@ static irqreturn_t pvcalls_front_conn_handler(int irq, void *sock_map)
> > return IRQ_HANDLED;
> > }
> >
> > +static void pvcalls_front_free_map(struct pvcalls_bedata *bedata,
> > + struct sock_mapping *map)
> > +{
> > + int i;
> > +
> > + spin_lock(&bedata->pvcallss_lock);
> > + if (!list_empty(&map->list))
> > + list_del_init(&map->list);
> > + spin_unlock(&bedata->pvcallss_lock);
> > +
> > + for (i = 0; i < (1 << map->active.ring->ring_order); i++)
> > + gnttab_end_foreign_access(map->active.ring->ref[i], 0, 0);
> > + gnttab_end_foreign_access(map->active.ref, 0, 0);
> > + free_page((unsigned long)map->active.ring);
> > + unbind_from_irqhandler(map->active.irq, map);
>
> Would it better to first unbind the handler? Any chance an interrupt
> might come in?
Fair enough, I'll do that.
> > +}
> > +
> > int pvcalls_front_socket(struct socket *sock)
> > {
> > struct pvcalls_bedata *bedata;
> > @@ -853,6 +870,77 @@ unsigned int pvcalls_front_poll(struct file *file, struct socket *sock,
> > return pvcalls_front_poll_passive(file, bedata, map, wait);
> > }
> >
> > +int pvcalls_front_release(struct socket *sock)
> > +{
> > + struct pvcalls_bedata *bedata;
> > + struct sock_mapping *map;
> > + int req_id, notify, ret;
> > + struct xen_pvcalls_request *req;
> > +
> > + if (!pvcalls_front_dev)
> > + return -EIO;
> > + bedata = dev_get_drvdata(&pvcalls_front_dev->dev);
> > +
> > + if (sock->sk == NULL)
> > + return 0;
>
> This can go above bedata access.
Yes, good idea.
> (You are going to address locking here so I won't review the rest)
Yes, I will. Thanks for the review! And sorry for taking so long to
come back to you.
next prev parent reply other threads:[~2017-09-08 23:09 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 22:57 [PATCH v3 00/13] introduce the Xen PV Calls frontend Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 01/13] xen/pvcalls: introduce the pvcalls xenbus frontend Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 02/13] xen/pvcalls: implement frontend disconnect Stefano Stabellini
2017-08-11 22:43 ` Boris Ostrovsky
2017-09-09 0:07 ` Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 03/13] xen/pvcalls: connect to the backend Stefano Stabellini
2017-08-11 22:55 ` Boris Ostrovsky
2017-09-09 0:14 ` Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 04/13] xen/pvcalls: implement socket command and handle events Stefano Stabellini
2017-08-13 0:42 ` Boris Ostrovsky
2017-09-08 23:20 ` Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 05/13] xen/pvcalls: implement connect command Stefano Stabellini
2017-08-13 1:12 ` Boris Ostrovsky
2017-09-08 21:23 ` Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 06/13] xen/pvcalls: implement bind command Stefano Stabellini
2017-08-13 1:22 ` Boris Ostrovsky
2017-09-08 21:46 ` Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 07/13] xen/pvcalls: implement listen command Stefano Stabellini
2017-08-13 1:28 ` Boris Ostrovsky
2017-07-31 22:57 ` [PATCH v3 08/13] xen/pvcalls: implement accept command Stefano Stabellini
2017-08-15 2:00 ` Boris Ostrovsky
2017-08-15 2:04 ` Boris Ostrovsky
2017-09-08 21:58 ` Stefano Stabellini
2017-09-08 22:16 ` Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 09/13] xen/pvcalls: implement sendmsg Stefano Stabellini
2017-08-15 2:31 ` Boris Ostrovsky
2017-09-08 23:48 ` Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 10/13] xen/pvcalls: implement recvmsg Stefano Stabellini
2017-08-15 2:39 ` Boris Ostrovsky
2017-09-08 23:11 ` Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 11/13] xen/pvcalls: implement poll command Stefano Stabellini
2017-08-15 20:30 ` Boris Ostrovsky
2017-09-08 23:03 ` Stefano Stabellini
2017-09-12 14:14 ` Boris Ostrovsky
2017-09-12 22:17 ` Stefano Stabellini
2017-09-12 23:04 ` Boris Ostrovsky
2017-09-12 23:13 ` Stefano Stabellini
2017-09-12 23:18 ` Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 12/13] xen/pvcalls: implement release command Stefano Stabellini
2017-08-15 20:44 ` Boris Ostrovsky
2017-09-08 23:09 ` Stefano Stabellini [this message]
2017-07-31 22:57 ` [PATCH v3 13/13] xen: introduce a Kconfig option to enable the pvcalls frontend Stefano Stabellini
2017-08-11 22:36 ` [PATCH v3 01/13] xen/pvcalls: introduce the pvcalls xenbus frontend Boris Ostrovsky
2017-08-10 15:07 ` [PATCH v3 00/13] introduce the Xen PV Calls frontend Boris Ostrovsky
2017-08-10 18:15 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1709081605500.19719@sstabellini-ThinkPad-X260 \
--to=sstabellini@kernel.org \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stefano@aporeto.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).