From: Thomas Gleixner <tglx@linutronix.de>
To: Tomi Sarvela <tomi.p.sarvela@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
x86@kernel.org, Peter Zijlstra <peterz@infradead.org>,
Martin Peres <martin.peres@linux.intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Marc Zyngier <marc.zyngier@arm.com>,
jeffy.chen@rock-chips.com
Subject: Re: [PATCH] x86/hpet: Cure interface abuse in the resume path
Date: Tue, 1 Aug 2017 09:43:27 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1708010939270.1919@nanos> (raw)
In-Reply-To: <05930667-0196-4393-85e3-8360ac69028f@intel.com>
On Tue, 1 Aug 2017, Tomi Sarvela wrote:
> On 31/07/17 23:07, Thomas Gleixner wrote:
> > The HPET resume path abuses irq_domain_[de]activate_irq() to restore the
> > MSI message in the HPET chip for the boot CPU on resume and it relies on an
> > implementation detail of the interrupt core code, which magically makes the
> > HPET unmask call invoked via a irq_disable/enable pair. This worked as long
> > as the irq code did unconditionally invoke the unmask() callback. With the
> > recent changes which keep track of the masked state to avoid expensive
> > hardware access, this does not longer work. As a consequence the HPET timer
> > interrupts are not unmasked which breaks resume as the boot CPU waits
> > forever that a timer interrupt arrives.
> >
> > Make the restore of the MSI message explicit and invoke the unmask()
> > function directly. While at it get rid of the pointless affinity setting as
> > nothing can change the affinity of the interrupt and the vector across
> > suspend/resume. The restore of the MSI message reestablishes the previous
> > affinity setting which is the correct one.
> >
> > Fixes: bf22ff45bed6 ("genirq: Avoid unnecessary low level irq function
> > calls")
> > Reported-by: Martin Peres <martin.peres@linux.intel.com>
> > Reported-by: Tomi Sarvela <tomi.p.sarvela@intel.com>
> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> > Cc: jeffy.chen@rock-chips.com
> > Cc: Marc Zyngier <marc.zyngier@arm.com>
> > Cc: Peter Ziljstra <peterz@infradead.org>
> > Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
>
> Tested-by: Tomi Sarvela <tomi.p.sarvela@intel.com>
>
> Tested only on the regressed Eagle Lake testhost. This patch fixes the
> suspend/resume issue.
Tomi, can you please do me a favor?
Use plain 4.13-rc3 (without that patch) and add the following on the kernel
command line: 'nohpet'. Boot the machine and capture and provide the output
of
# dmesg
# cat /proc/interrupts
# cat /proc/timer_list
Then try the suspend cycle again.
Thanks,
tglx
next prev parent reply other threads:[~2017-08-01 7:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 20:07 [PATCH] x86/hpet: Cure interface abuse in the resume path Thomas Gleixner
2017-07-31 22:22 ` Rafael J. Wysocki
2017-08-01 7:30 ` Tomi Sarvela
2017-08-01 7:43 ` Thomas Gleixner [this message]
2017-08-01 8:21 ` Tomi Sarvela
2017-08-01 10:59 ` Thomas Gleixner
2017-08-01 11:07 ` [tip:x86/urgent] " tip-bot for Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1708010939270.1919@nanos \
--to=tglx@linutronix.de \
--cc=jeffy.chen@rock-chips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=martin.peres@linux.intel.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=tomi.p.sarvela@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).