From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C176DC282CE for ; Fri, 5 Apr 2019 18:16:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 90EDD20989 for ; Fri, 5 Apr 2019 18:16:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731670AbfDESQK (ORCPT ); Fri, 5 Apr 2019 14:16:10 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:49449 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728683AbfDESQK (ORCPT ); Fri, 5 Apr 2019 14:16:10 -0400 Received: from p5492e2fc.dip0.t-ipconnect.de ([84.146.226.252] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1hCTNl-0001pj-5N; Fri, 05 Apr 2019 20:16:05 +0200 Date: Fri, 5 Apr 2019 20:16:04 +0200 (CEST) From: Thomas Gleixner To: Len Brown cc: Dave Hansen , X86 ML , linux-kernel@vger.kernel.org, Len Brown , linux-doc@vger.kernel.org Subject: Re: [PATCH 04/14] x86 topology: Add CPUID.1F multi-die/package support In-Reply-To: Message-ID: References: <204e9bf2afff8e6cb7a8a39d86038075f1bb4ab8.1551160674.git.len.brown@intel.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 28 Feb 2019, Len Brown wrote: > On Tue, Feb 26, 2019 at 2:46 PM Dave Hansen wrote: > > I wonder if we'll end up with different (better) infrastructure if we do > > these all at once instead of hacking them in one at a time. > > Assuming that "hacking in" is a derogatory term, let me make the case > that this patch series cleanly sets the stage for the future. > > old: > > thread_siblings: the threads that are in the same core > core_siblings: the threads that are in the same package > > This naming scheme assumed that there would never be a topology level > between a core and a package. Though we leave "core_siblings" intact > for legacy SW that depends on it, we mark it depreciated. > > new: > > core_threads: the threads in the same core > die_threads: the threads in the same die > package_threads: the threads in the same package > > So in the future we could always add... > > dave_threads: the threads in the same dave > > So I think we are ready for whatever the future may throw at us, > while remaining compatible, consistent, and no "hacking in" required. Makes sense. tglx