From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A492C10F06 for ; Sat, 6 Apr 2019 06:31:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 139472186A for ; Sat, 6 Apr 2019 06:31:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726424AbfDFGbx (ORCPT ); Sat, 6 Apr 2019 02:31:53 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:8816 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725934AbfDFGbx (ORCPT ); Sat, 6 Apr 2019 02:31:53 -0400 X-IronPort-AV: E=Sophos;i="5.60,315,1549926000"; d="scan'208";a="302005497" Received: from abo-75-106-68.mrs.modulonet.fr (HELO hadrien) ([85.68.106.75]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Apr 2019 08:31:49 +0200 Date: Sat, 6 Apr 2019 08:31:49 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Himanshu Jha cc: yamada.masahiro@socionext.com, Julia Lawall , Gilles Muller , nicolas.palix@imag.fr, michal.lkml@markovi.net, linux-kernel@vger.kernel.org, cocci@systeme.lip6.fr, bgolaszewski@baylibre.com, gregkh@linuxfoundation.org, andriy.shevchenko@linux.intel.com, linus.walleij@linaro.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] coccinelle: api: add devm_platform_ioremap_resource script In-Reply-To: <20190406061112.31620-1-himanshujha199640@gmail.com> Message-ID: References: <20190406061112.31620-1-himanshujha199640@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 6 Apr 2019, Himanshu Jha wrote: > Use recently introduced devm_platform_ioremap_resource > helper which wraps platform_get_resource() and > devm_ioremap_resource() together. This helps produce much > cleaner code while removing local `struct resource` declaration. > > Signed-off-by: Himanshu Jha Acked-by: Julia Lawall Thanks for taking up this issue. julia > --- > > Tree wide changes has been tested through 0-day test service > with build success. > > BUILD SUCCESS 74ebaaca5d14d3d9b03e911f0b4995b78a4d60f0 > tree/branch: https://github.com/himanshujha199640/linux-next 20190401-devm_platform_ioremap_resource-final > branch HEAD: 74ebaaca5d14d3d9b03e911f0b4995b78a4d60f0 Coccinelle: api: Add devm_platform_ioremap_resource.cocci > > elapsed time: 385m > configs tested: 162 > > > Stats: > 916 files changed, 1028 insertions(+), 2921 deletions(-) > > Note: cases where the `struct resource *res` variable is > used subsequently in the function have been ignored out because > those cases produce: > > eg., drivers/bus/da8xx-mstpri.c > > warning: 'res' may be used uninitialized in this function [-Wmaybe-uninitialized] > > due to: > if (prio_descr->reg + sizeof(u32) > resource_size(res)) { > > which seems correct as `res` isn't initialized in the scope of > the function(da8xx_mstpri_probe) and instead initialized inside: > > void __iomem *devm_platform_ioremap_resource(struct platform_device *pdev, > unsigned int index) > { > struct resource *res; > > res = platform_get_resource(pdev, IORESOURCE_MEM, index); > return devm_ioremap_resource(&pdev->dev, res); > } > EXPORT_SYMBOL_GPL(devm_platform_ioremap_resource); > > > .../api/devm_platform_ioremap_resource.cocci | 63 +++++++++++++++++++ > 1 file changed, 63 insertions(+) > create mode 100644 scripts/coccinelle/api/devm_platform_ioremap_resource.cocci > > diff --git a/scripts/coccinelle/api/devm_platform_ioremap_resource.cocci b/scripts/coccinelle/api/devm_platform_ioremap_resource.cocci > new file mode 100644 > index 000000000000..a28274af14df > --- /dev/null > +++ b/scripts/coccinelle/api/devm_platform_ioremap_resource.cocci > @@ -0,0 +1,63 @@ > +/// Use devm_platform_ioremap_resource helper which wraps > +/// platform_get_resource() and devm_ioremap_resource() together. > +/// > +// Confidence: High > +// Copyright: (C) 2019 Himanshu Jha GPLv2. > +// Copyright: (C) 2019 Julia Lawall, Inria/LIP6. GPLv2. > +// Keywords: platform_get_resource, devm_ioremap_resource, > +// Keywords: devm_platform_ioremap_resource > + > +virtual patch > +virtual report > + > +@r depends on patch && !report@ > +expression e1, e2, arg1, arg2, arg3, arg4; > +identifier id; > +@@ > + > +( > +- id = platform_get_resource(arg1, arg2, arg3); > +| > +- struct resource *id = platform_get_resource(arg1, arg2, arg3); > +) > + ... when != id > +- e1 = devm_ioremap_resource(arg4, id); > ++ e1 = devm_platform_ioremap_resource(arg1, arg3); > + ... when != id > +? id = e2 > + > +@r1 depends on patch && !report@ > +identifier r.id; > +type T; > +@@ > + > +- T *id; > + ...when != id > + > +// ---------------------------------------------------------------------------- > + > +@r2 depends on report && !patch@ > +identifier id; > +expression e1, e2, arg1, arg2, arg3, arg4; > +position j0; > +@@ > + > +( > + id = platform_get_resource(arg1, arg2, arg3); > +| > + struct resource *id = platform_get_resource(arg1, arg2, arg3); > +) > + ... when != id > + e1@j0 = devm_ioremap_resource(arg4, id); > + ... when != id > +? id = e2 > + > +// ---------------------------------------------------------------------------- > + > +@script:python depends on report && !patch@ > +e1 << r2.e1; > +j0 << r2.j0; > +@@ > + > +msg = "WARNING: Use devm_platform_ioremap_resource for %s" % (e1) > +coccilib.report.print_report(j0[0], msg) > -- > 2.17.1 > >